-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs update #62
Docs update #62
Conversation
Ran into an issue for the end-to-end example: It would make more sense for a purchase to have a list of items rather than just a single item. workaround option 1As a workaround, I am treating Another side effect of this workaround is that it's possible for multiple users to take part in a single purchase, which I think is fine. workaround option 2A different option would be to make purchase ID a uuid and say that every purchase can only be for one item. This is a little neater in that a purchase would have only one user associated. I don't like it as much as option 1 though because it's more boring. conclusionI think when we implement lists, it would be good to refactor this back into each purchase having a list of items so that only one user is a part of every purchase. |
…red when no sr url is found
973697b
to
3d3e8da
Compare
I’ll go ahead and merge this for now and I’ll take feedback and do a follow-on PR |
* move -s before -f and modify wording of -c description * skip schema registration on dry run * add alert library to schema registry config so proper alert is triggered when no sr url is found * bump version to 0.1.3 * add example-schemas folder * remove extraneous hydra.key from avsc file * update readme * rename compose.yml to docker-compose.yml for clarity * rename and move files * remove unused code in sql parser * make sql parser pick up primary key * work in progress ecommerce demo * work on end to end example * work on ecommerce tutorial * finish draft of end-to-end tutorial * small bugfix for producer * add new --prefix option to readme
What type of PR is this? (check all applicable)
Description
Giving the documentation a facelift, as well as some minor aesthetic changes. Still on progress on a longer end-to-end demo with Materialize.