Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] Feat: Add state + fix sources + views #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joacoc
Copy link
Contributor

@joacoc joacoc commented Mar 1, 2023

Rust version https://github.com/MaterializeInc/developer-experience/issues/217#event-8578542249

  • Extend Subscriptions with State
  • Update create source code
  • Update view creation to match the source code
  • Add sslmode to connection string and add the TLS connector

@joacoc joacoc requested review from petrosagg and bobbyiliev March 1, 2023 14:10
@joacoc joacoc marked this pull request as ready for review March 1, 2023 14:10
@@ -0,0 +1,95 @@
#[derive(Debug, Clone)]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think if this makes it to documentation/example code rather than a demo we could do a bit better. What is the surrounding context of this? Does it end up in our documentation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tagging @morsapaes since I'm unsure about the future of this code.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples in this repo are used as a basis for the existing integration guides in the documentation (no Rust one in there yet). We plan to make these runnable end-to-end, at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants