Show version in demo app #3770
Merged
Show version in demo app #3770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#3736 I added some suggestions as a cloud patch (let me know if you have any trouble viewing it). Some key changes here: 1. You can access the environment variables to get the versions. I left some code showing how to do this. 2. You can setup a string property in the view model and bind that in the XAML rather than the code behind. 3. There are several TODO items I left in the cloud patch, let me know if you have any questions on them. 4. If you want to see my review of this, I did it it live on twitch. It is at the beginning of this stream. https://www.twitch.tv/videos/2318667161
Updating the MainWindowViewModel to use the MVVM toolkit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to #3736