Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue with pipeline milestone closing not using right version number #3755

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Fixing issue with pipeline milestone closing not using right version number #3755

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,14 +258,15 @@ jobs:
steps:
# Doing a checkout, until this issue is resolved.
# https://github.com/valeriobelli/gh-milestone/issues/15
# As of version 2.1.0 the -R doesn't appear to output valid json when filtering. So still using the checkout.
- uses: actions/checkout@v4

- name: Close Milestone
run: |
gh extension install valeriobelli/gh-milestone
Write-Host "Using extension version $(gh milestone --version)"
$milestones = $(gh milestone list --json number,title) | ConvertFrom-Json
$milestoneNumber = ($milestones | Where-Object { $_.title -eq "5.1.0" }).number
$milestoneNumber = ($milestones | Where-Object { $_.title -eq "${{ inputs.milestone }}" }).number
gh milestone edit $milestoneNumber --state closed
env:
GITHUB_TOKEN: ${{ secrets.SA_PAT }}
Expand All @@ -277,7 +278,7 @@ jobs:
environment: production

permissions:
actions: write
actions: write

steps:
# Checkout is needed so that we can update the get_versions.yml file
Expand Down
Loading