Update README #53
Merged
Update README #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joseph-neeraj
commented
Nov 7, 2024
•
joseph-neeraj
commented
joseph-neeraj
force-pushed
the
docs/update-readme
branch
3 times, most recently
from
afb5361 to
e42fa1e
Compare
joseph-neeraj
force-pushed
the
docs/update-readme
branch
5 times, most recently
from
d908dab to
ec467b8
Compare
joseph-neeraj
force-pushed
the
docs/update-readme
branch
from
ec467b8 to
12f4735
Compare
karen-avetisyan-mc
requested changes
Nov 11, 2024
docs/configuration-examples.md
Outdated
| ``` | ||
| ### Mastercard Encryption Real world example | ||
|
|
||
| This is a real world configuration for the [Donations API](https://developer.mastercard.com/donations/documentation/service_config/), which uses Mastercard Encryption. |
There was a problem hiding this comment.
Please remove the mention of Donations API, Once petstore is ready, we can use it. For now, just state This is a configuration example, for an API, uses Mastercard Encryption
docs/configuration-examples.md
Outdated
| ### Mastercard Encryption Real world example | ||
|
|
||
| This is a real world configuration for the [Donations API](https://developer.mastercard.com/donations/documentation/service_config/), which uses Mastercard Encryption. | ||
| See the [API documentation](https://developer.mastercard.com/donations/documentation/service_config/) for details. |
There was a problem hiding this comment.
please remove this
docs/configuration-examples.md
Outdated
| ``` | ||
|
|
||
| ### JWE Encryption Real World Example | ||
| This is a real world configuration for the [Mastercard Installments API](https://developer.mastercard.com/unified-installments/documentation/api-basics/#group-1), which uses JWE Encryption. |
There was a problem hiding this comment.
Same comment here
karen-avetisyan-mc
requested changes
Nov 12, 2024
docs/configuration-examples.md
Outdated
| // defaults to ["mastercard.com","api.ethocaweb.com"] | ||
| "appliesTo": [ | ||
| "mastercard.com", | ||
| "api.ethocaweb.com" |
There was a problem hiding this comment.
please remove this
docs/configuration-examples.md
Outdated
| // defaults to ["mastercard.com","api.ethocaweb.com"] | ||
| "appliesTo": [ | ||
| "mastercard.com", | ||
| "api.ethocaweb.com" |
There was a problem hiding this comment.
same, please remove this
| "modified": 1572606757333, | ||
| "created": 1572009619195, | ||
| "url": "{{ host }}/atms/v1/atm?PageOffset=0&PageLength=5&PostalCode=11101&Format=JSON", | ||
| "name": "Mastercard ATM Location (update me!)", |
There was a problem hiding this comment.
Please rename it to Mastercard Service I want to use
| "modified": 1572606757333, | ||
| "created": 1572009619195, | ||
| "url": "{{ host }}/atms/v1/atm?PageOffset=0&PageLength=5&PostalCode=11101&Format=JSON", | ||
| "name": "Mastercard ATM Location (update me!)", |
joseph-neeraj
force-pushed
the
docs/update-readme
branch
from
3f32ea2 to
d6d9814
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.