Issue78 optimize integrals #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MassimoCimmino
changed the base branch from
master
to
issue33_CommongFunctionInterface
MassimoCimmino
force-pushed
the
issue33_CommongFunctionInterface
branch
2 times, most recently
from
502f64a to
aad279c
Compare
MassimoCimmino
force-pushed
the
issue78_optimizeIntegrals
branch
2 times, most recently
from
061ed54 to
3d64c27
Compare
|
This is also ready for review. The new implementations can be tested in issue78-compare_detailed and issue78-compare_similarities. These to files will be removed before merge. Before merge:
|
MassimoCimmino
force-pushed
the
issue78_optimizeIntegrals
branch
2 times, most recently
from
6486f6a to
de898fa
Compare
MassimoCimmino
force-pushed
the
issue33_CommongFunctionInterface
branch
from
08975c0 to
916c658
Compare
MassimoCimmino
force-pushed
the
issue78_optimizeIntegrals
branch
2 times, most recently
from
a00ef83 to
f2c63cc
Compare
MassimoCimmino
changed the base branch from
issue33_CommongFunctionInterface
to
master
MassimoCimmino
force-pushed
the
issue78_optimizeIntegrals
branch
from
f2c63cc to
f5ac538
Compare
The optimized solver introduces an intermediate step in the identification of similarities. Similarities between boreholes are checked first (we assume that only similar pairs of boreholes contain similar pairs of segments. The integral in the finite line source (FLS) solution is now calculated using `scipy.integrate.quad_vec` to speed up calculations. FLS solutions at `r=r_b` is calculated separately from other distances because the integrand functions have shapes that are too dissimilar (calculation time increases if they are computed at the same time).
MassimoCimmino
force-pushed
the
issue78_optimizeIntegrals
branch
2 times, most recently
from
ce8a471 to
da85074
Compare
finite_line_source() and finite_line_source_vectorized are now more flexible with regards to their acceptable inputs. This makes their use more readable in the code. It will be useful in the future if other solutions (e.g. inclined boreholes, groundwater flow) or special cases (e.g. steady-state) are added.
The algorithm now makes proper use of quad_vec
MassimoCimmino
force-pushed
the
issue78_optimizeIntegrals
branch
from
da85074 to
841e011
Compare
MassimoCimmino
force-pushed
the
issue78_optimizeIntegrals
branch
2 times, most recently
from
7d8561c to
979209d
Compare
MassimoCimmino
force-pushed
the
issue78_optimizeIntegrals
branch
from
979209d to
fc6a817
Compare
|
This is ready to merge. Benchmarks and validation are in #78. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #78.