Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upload to pypi step in workflow #243

Merged

Conversation

j-c-cook
Copy link
Contributor

closes #230

@MassimoCimmino
Copy link
Owner

Thanks @j-c-cook.

Is there a way to test this without publishing a release, or do we have to test it on a release candidate version?

I probably need to configure the secrets on the project.

@mitchute
Copy link
Contributor

@MassimoCimmino you can configure it to push to https://test.pypi.org/ for testing purposes. You may need to modify the deployment action to include a repository_url, and then have separate secrets for test.pypi.org.

@j-c-cook
Copy link
Contributor Author

Without modifying the current workflow, I think you would need to publish a release candidate to test it.

Matt seems to be proposing an alternative. Which would require if: github.event.release && github.event.action == 'published' to be temporarily removed for the test to run without a release being created.

@mitchute
Copy link
Contributor

@MassimoCimmino see here for an example. Changing the url to https://test.upload.pypi.org/legacy/ will push it to test.pypi.org if you like during your testing.

@j-c-cook
Copy link
Contributor Author

@MassimoCimmino see here for an example. Changing the url to https://test.upload.pypi.org/legacy/ will push it to test.pypi.org if you like during your testing.

Please note that "here" is not currently a hyper-reference.

@mitchute
Copy link
Contributor

@MassimoCimmino MassimoCimmino merged commit 999f254 into MassimoCimmino:master Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish on release workflow
3 participants