-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rules: different, uuid, distinct, required_if, required_with #44
Add rules: different, uuid, distinct, required_if, required_with #44
Conversation
@josephmancuso ready for review :) ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it. Left some small requests
@josephmancuso I made the changes ! |
Should we merge it in 3.0 or 2.X ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me :)
different
rule (more handy than doingisnt(equals("field"))
)uuid
rulerequired
rule (check Inconsistency between exists and required validation rule #45)distinct
rulerequired_if
rulerequired_with
rule