Improve URL detection in auto_hyperlinks example

[24rr]

Fixes #141

[MarshalX]

Hi thank you! Could pls return blank empty line? Linter fails

[24rr]

Hi thank you! Could pls return blank empty line? Linter fails

Where do I return it?

[MarshalX]

Hi thank you! Could pls return blank empty line? Linter fails

Where do I return it?

Please check changes tab or GitHub actions logs. Line number 6. Between imports and function definition

[24rr]

Hi thank you! Could pls return blank empty line? Linter fails

Where do I return it?

Please check changes tab or GitHub actions logs. Line number 6. Between imports and function definition

Oh my bad. Done

[MarshalX]

@editor-syntax did i something wrong? just testing your regex with example from the issue

https://regex101.com/r/d3Hg78/1

[24rr]

@editor-syntax did i something wrong? just testing your regex with example from the issue

https://regex101.com/r/d3Hg78/1

Nope, but I did something wrong lol. It's updated now.

[MarshalX]

now it doesnt work for links without (/) :(

[24rr]

now it doesnt work for links without (/) :(

Updated. That's my last resort lol!

[MarshalX]

@editor-syntax it looks working. But you deleted the usage of "aggressive" bool. Now we have only 1 regex. But you didn't delete the argument of the function. If we are gonna delete "aggressive" mode we should remove all related things to it:

1. argument in the function
   

   atproto/examples/advanced_usage/auto_hyperlinks.py

   Line 8 in 5505bd1

   text: str, *, aggressive: bool, encoding: str = 'UTF-8'

2. tune docstring of the function
   

   atproto/examples/advanced_usage/auto_hyperlinks.py

   Line 10 in 5505bd1

   """If aggressive is False, only links beginning http or https will be detected"""

3. remove flag from here:
   

   atproto/examples/advanced_usage/auto_hyperlinks.py

   Line 35 in 5505bd1

   url_positions = extract_url_byte_positions(text, aggressive=True)

4. remove this because now we will not have matches for links without protocol
   

   atproto/examples/advanced_usage/auto_hyperlinks.py

   Line 40 in 5505bd1

   uri = link[0] if link[0].startswith('http') else f'https://{link[0]}'

[24rr]

@editor-syntax it looks working. But you deleted the usage of "aggressive" bool. Now we have only 1 regex. But you didn't delete the argument of the function. If we are gonna delete "aggressive" mode we should remove all related things to it:

1. argument in the function
   

   atproto/examples/advanced_usage/auto_hyperlinks.py

   Line 8 in 5505bd1

   text: str, *, aggressive: bool, encoding: str = 'UTF-8'

2. tune docstring of the function
   

   atproto/examples/advanced_usage/auto_hyperlinks.py

   Line 10 in 5505bd1

   """If aggressive is False, only links beginning http or https will be detected"""

3. remove flag from here:
   

   atproto/examples/advanced_usage/auto_hyperlinks.py

   Line 35 in 5505bd1

   url_positions = extract_url_byte_positions(text, aggressive=True)

4. remove this because now we will not have matches for links without protocol
   

   atproto/examples/advanced_usage/auto_hyperlinks.py

   Line 40 in 5505bd1

   uri = link[0] if link[0].startswith('http') else f'https://{link[0]}'

Yes, we can do that. I'll edit the example code and you edit the rest

[MarshalX]

thank you!