Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scroll issues for drawer and home pages #2820

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

phixMe
Copy link
Member

@phixMe phixMe commented May 21, 2024

Problem

Prevents scrollbars from appearing when they should not and ensures that they actually remain in frame of the scrolling portion of the screen in regards to our drawers for a job, dataset, and column dataset.

One-line summary: Scrolling improvements for drawer and home pages.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the web label May 21, 2024
Copy link

netlify bot commented May 21, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 00479bb
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/664cd63cc190180008e98b2d

@phixMe phixMe changed the title Scroll issues for drawer and status. Fix scroll issues for drawer and home pages May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.57%. Comparing base (8e448ce) to head (00479bb).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2820   +/-   ##
=========================================
  Coverage     84.57%   84.57%           
  Complexity     1441     1441           
=========================================
  Files           251      251           
  Lines          6503     6503           
  Branches        302      302           
=========================================
  Hits           5500     5500           
  Misses          850      850           
  Partials        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wslulciuc wslulciuc added this to the 0.48.0 milestone May 21, 2024
Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@wslulciuc wslulciuc merged commit 12775e1 into main May 21, 2024
17 checks passed
@wslulciuc wslulciuc deleted the web/scroll-fixes branch May 21, 2024 17:38
jonathanpmoraes pushed a commit to nubank/NuMarquez that referenced this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants