Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.0.x - U8G HAL LCD support - Arduino IDE compatibility #8341

Merged
merged 1 commit into from
Nov 9, 2017
Merged

2.0.x - U8G HAL LCD support - Arduino IDE compatibility #8341

merged 1 commit into from
Nov 9, 2017

Conversation

Bob-the-Kuhn
Copy link
Contributor

  1. Changed includes to make Arduino IDE happy
  2. Removed unused device definitions in u8g_dev_ssd1306_sh1106_128x64_I2C.cpp. Arduino Beta correctly complained that they were duplicates of ones in the U8G library.
  3. platformio.ini - Put U8glib-HAL back into the common section. Item 1) appears to have fixed the issues that resulted in PR 2.0.x - U8G HAL LCD support - platformio.ini correction #8338

This compiled with the Arduino Beta but not the Arduino nightly build. The Arduino nightly build gave a "file name too long" error.

@Bob-the-Kuhn
Arduini IDE compatibility changes
d47fbf7 
changed includes to make Arduino IDE happy
@Bob-the-Kuhn Bob-the-Kuhn merged commit 10896b9 into MarlinFirmware:bugfix-2.0.x Nov 9, 2017
@Bob-the-Kuhn Bob-the-Kuhn mentioned this pull request Nov 9, 2017
Closed
@Bob-the-Kuhn Bob-the-Kuhn deleted the u8g-try-4-Arduino-IDE-compatibility branch November 10, 2017 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Bob-the-Kuhn