[1.1.x] Support some more LCD types #7824

jmdearras · 2017-10-02T19:28:32Z

Added 4 displays

original CR-10 and MKS Minidisplay

Roxy-3D · 2017-10-02T21:05:57Z

All of the example/configuration.h files need to be changed also.

fiveangle · 2017-10-03T02:42:19Z

Marlin/Conditionals_LCD.h

@@ -108,7 +108,26 @@
    #define ULTIPANEL
    #define NEWPANEL

-  #endif
+  #elif ENABLED(CR10_stockdisplay)


Since these are just delays specific to this board when using that display, shouldn't these be (and already are in) pins_MELZI_CREALITY.h ?

https://github.com/MarlinFirmware/Marlin/blob/1.1.x/Marlin/pins_MELZI_CREALITY.h#L60-L63

I was looking at something else and saw this, so I think your REVERSE_MENU_DIRECTION might over-rided by Configuration.h without including any ifdef/ifenabled checks (although it mentions only pins.h and Configuration_adv.h):

/** * Conditionals_LCD.h * Conditionals that need to be set before Configuration_adv.h or pins.h */ #ifndef CONDITIONALS_LCD_H // Get the LCD defines which are needed first

To be 100% sure, just put your changes into Conditionals_LCD.h, then compile / load on your printer with and without REVERSE_MENU_DIRECTION set in Configuration.h and ensure it changes. If it does, you should be good so no changes would be needed.

See my comment on next code block re: define precedence, which may make this okay to keep as well.

I removed the menu direction

fiveangle · 2017-10-03T02:45:26Z

Marlin/Conditionals_LCD.h

+    #define U8GLIB_SH1106 
+    #define REPRAP_DISCOUNT_SMART_CONTROLLER 
+    #define NEWPANEL 
+    #define REVERSE_MENU_DIRECTION


Won't this override in all circumstances for this display ? Doesn't this need to honor REVERSE_MENU_DIRECTION if set in Configuration.h ?

I was looking at something else and saw this, so I think your REVERSE_MENU_DIRECTION might over-rided by Configuration.h without including any ifdef/ifenabled checks (although it mentions only pins.h and Configuration_adv.h):

/** * Conditionals_LCD.h * Conditionals that need to be set before Configuration_adv.h or pins.h */ #ifndef CONDITIONALS_LCD_H // Get the LCD defines which are needed first

To be 100% sure, just put your changes into Conditionals_LCD.h, then compile / load on your printer with and without REVERSE_MENU_DIRECTION set in Configuration.h and ensure it changes. If it does, you should be good so no changes would be needed.

fiveangle

just a few things i was curious about

fiveangle · 2017-10-03T02:48:05Z

Marlin/ultralcd_impl_DOGM.h

  // Generic support for SH1106 OLED I2C LCDs
  //U8GLIB_SH1106_128X64 u8g(U8G_I2C_OPT_NONE | U8G_I2C_OPT_FAST);  // 8 stripes
-  U8GLIB_SH1106_128X64_2X u8g(U8G_I2C_OPT_NONE | U8G_I2C_OPT_FAST); // 4 stripes
+  U8GLIB_SH1106_128X64_2X u8g(U8G_I2C_OPT_NONE | U8G_I2C_OPT_FAST); // 4 stripes //bunnyhack


What is "bunnyhack" ? :)

place keeper, sorry, removed!

fiveangle · 2017-10-03T03:07:18Z

Marlin/Configuration.h

+// Makeboard 3D Printer Parts 3D Printer Mini Display 1602 Mini Controller
+
+//#define MAKEBOARD_MINI_2_LINE_DISPLAY_1602
+
 //


Normally new panels are added at the end of the list so that people who are intimately familiar with the Config format can easily find the section start when scanning through it. Regardless, the entry should also match the comment style:

// // panel name // link to external info on the panel (ideally reprap.org wiki page) // // any notes (optional) // //#define PANEL_DEFINE_NAME

jmdearras · 2017-10-03T16:19:22Z

This makes the stock display global, works on other boards so CR-10 owners can upgrade the board and keep the case/display. Jim

…

On Mon, Oct 2, 2017 at 10:42 PM, Dave Johnson ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In Marlin/Conditionals_LCD.h <#7824 (comment)> : > @@ -108,7 +108,26 @@ #define ULTIPANEL #define NEWPANEL - #endif + #elif ENABLED(CR10_stockdisplay) Since these are just delays specific to this board when using that display, shouldn't these be (and already are in) pins_MELZI_CREALITY.h ? https://github.com/MarlinFirmware/Marlin/blob/1.1.x/Marlin/pins_MELZI_ CREALITY.h#L60-L63 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7824 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAksiWZmmXPVeBuBmWQIDGLdOLzvX8cBks5soZ8igaJpZM4PrIQI> .

jmdearras · 2017-10-03T16:20:37Z

I have seen REVERSE_MENU_DIRECTION coded in other displays, I can remove it.

…

On Mon, Oct 2, 2017 at 10:45 PM, Dave Johnson ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In Marlin/Conditionals_LCD.h <#7824 (comment)> : > @@ -108,7 +108,26 @@ #define ULTIPANEL #define NEWPANEL - #endif + #elif ENABLED(CR10_stockdisplay) + + #define REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER + #define ST7920_DELAY_1 DELAY_2_NOP + #define ST7920_DELAY_2 DELAY_2_NOP + #define ST7920_DELAY_3 DELAY_2_NOP + + #elif ENABLED (MKS_OLED13_128x64_FULL_GRAPHICS_CONTROLLER) + + #define U8GLIB_SH1106 + #define REPRAP_DISCOUNT_SMART_CONTROLLER + #define NEWPANEL + #define REVERSE_MENU_DIRECTION Won't this override in all circumstances for this display ? Doesn't this need to honor REVERSE_MENU_DIRECTION if set in Configuration.h ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7824 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAksiW3sqbLbH684d9Rux9NJ-Qslsfaoks5soZ_VgaJpZM4PrIQI> .

jmdearras · 2017-10-03T22:13:00Z

I am new to making modifications to the marlin code. I have bought several boards and displays to use in modifying my printers and made the changes to get them working, all displays to all boards I have. Is there a prefered protocol to submit changes? I will follow them if there is a reasonable chance they will be accepted. Jim De Arras

…

On Tue, Oct 3, 2017 at 12:20 PM, Jim DeArras ***@***.***> wrote: I have seen REVERSE_MENU_DIRECTION coded in other displays, I can remove it. On Mon, Oct 2, 2017 at 10:45 PM, Dave Johnson ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In Marlin/Conditionals_LCD.h > <#7824 (comment)> > : > > > @@ -108,7 +108,26 @@ > #define ULTIPANEL > #define NEWPANEL > > - #endif > + #elif ENABLED(CR10_stockdisplay) > + > + #define REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER > + #define ST7920_DELAY_1 DELAY_2_NOP > + #define ST7920_DELAY_2 DELAY_2_NOP > + #define ST7920_DELAY_3 DELAY_2_NOP > + > + #elif ENABLED (MKS_OLED13_128x64_FULL_GRAPHICS_CONTROLLER) > + > + #define U8GLIB_SH1106 > + #define REPRAP_DISCOUNT_SMART_CONTROLLER > + #define NEWPANEL > + #define REVERSE_MENU_DIRECTION > > Won't this override in all circumstances for this display ? Doesn't this > need to honor REVERSE_MENU_DIRECTION if set in Configuration.h ? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#7824 (review)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAksiW3sqbLbH684d9Rux9NJ-Qslsfaoks5soZ_VgaJpZM4PrIQI> > . >

fiveangle · 2017-10-03T23:12:42Z

There is not necessarily a "right" or "wrong" way, but I did pose some comments and questions in your code. For REVERSE_MENU_DIRECTION, as long as the value in Configuration*.h over-rides the value you added, then it should be fine. If not, it probably should be left out and the user make the change in Config. If you think what you have is correct, Scott can review when he merges.

The other things Roxy and I left you didn't respond to (bunnyhack ? moving new panel to end of list, fixing comment format, updating the rest of the configs, etc). The protocol is to post your PR like you have, and then respond to comments made (you need to go to the website and respond to the review as you cannot easily do it via email).

jmdearras · 2017-10-04T00:36:32Z

can I withdraw the merge, and cleanup the items you and other pointed out, and then resubmit? Jim

…

On Tue, Oct 3, 2017 at 7:12 PM, Dave Johnson ***@***.***> wrote: There is not necessarily a "right" or "wrong" way, but I did pose some comments and questions in your code. For REVERSE_MENU_DIRECTION, as long as the value in Configuration*.h over-rides the value you added, then it should be fine. If not, it probably should be left out and the user make the change in Config. If you think what you have is correct, Scott can review when he merges (but if he agrees that it is wrong, then it may delay getting merged if you have to fix it. The other things Roxy and I left weren't responded to (bunnyhack ? moving new panel to end of list, fixing comment format, updating the rest of the configs, etc) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7824 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAksiXnXB-CqMb6VDbmFIgcfQpakyDosks5sor93gaJpZM4PrIQI> .

jmdearras · 2017-10-04T00:39:06Z

oh, and do I really need to update all the example configuration.h files? I do not like to edit what I cannot test well.

…

On Tue, Oct 3, 2017 at 8:36 PM, Jim DeArras ***@***.***> wrote: can I withdraw the merge, and cleanup the items you and other pointed out, and then resubmit? Jim On Tue, Oct 3, 2017 at 7:12 PM, Dave Johnson ***@***.***> wrote: > There is not necessarily a "right" or "wrong" way, but I did pose some > comments and questions in your code. For REVERSE_MENU_DIRECTION, as long as > the value in Configuration*.h over-rides the value you added, then it > should be fine. If not, it probably should be left out and the user make > the change in Config. If you think what you have is correct, Scott can > review when he merges (but if he agrees that it is wrong, then it may delay > getting merged if you have to fix it. > > The other things Roxy and I left weren't responded to (bunnyhack ? moving > new panel to end of list, fixing comment format, updating the rest of the > configs, etc) > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#7824 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAksiXnXB-CqMb6VDbmFIgcfQpakyDosks5sor93gaJpZM4PrIQI> > . >

Tannoo · 2017-10-04T03:38:44Z

Once you have the config files the way you want... you do have to update all of the example config files to match.

fiveangle · 2017-10-04T12:11:50Z

I suggest leave this open and just fix it.

I was looking at something else and noticed that Conditionals_LCD.h might load before Configuration.h so you may fine there (I commented on that code directly, so take a look).

jmdearras · 2017-10-04T15:47:37Z

I hate to sound stupid, but how do I fix it if it's open?

…

On Wed, Oct 4, 2017 at 8:12 AM, Dave Johnson ***@***.***> wrote: I suggest leave this open and just fix it. I was looking at something else and checked this, so I think your REVERSE_MENU_DIRECTION will in fact be over-rided by Configuration*.h without including any ifdef/ifenabled checks: /** * Conditionals_LCD.h * Conditionals that need to be set before Configuration_adv.h or pins.h */ #ifndef CONDITIONALS_LCD_H // Get the LCD defines which are needed first So disregard that comment from me. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7824 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAksidxqpDhNSXkgzDzH1dxBjBgRbTL1ks5so3YTgaJpZM4PrIQI> .

fiveangle · 2017-10-04T17:38:41Z

Fix in your local repo then commit to your "Marlin-wip" branch which you have requested the merge for here. Also, you really should start interacting on the website, as I mentioned... as the email interface is too limiting. Click the "view on github" link, then re-read the info we've put here as a start.

thinkyhead · 2017-10-04T17:52:26Z

I hate to sound stupid, but how do I fix it if it's open?

Any commits you add (and push) to your branch will show up here.

thinkyhead · 2017-10-04T17:55:08Z

@jmdearras I have no problem using the CR-10 example configurations included in the current "nightly" build of Marlin. Are you having issues with them?

thinkyhead · 2017-10-04T17:58:37Z

Marlin/SanityCheck.h

@@ -1146,7 +1146,7 @@ static_assert(1 >= 0
 static_assert(1 >= 0
  #if ENABLED(ULTIMAKERCONTROLLER) \
      && DISABLED(SAV_3DGLCD) && DISABLED(miniVIKI) && DISABLED(VIKI2) \
-      && DISABLED(ELB_FULL_GRAPHIC_CONTROLLER) && DISABLED(PANEL_ONE)
+      && DISABLED(ELB_FULL_GRAPHIC_CONTROLLER) && DISABLED(PANEL_ONE) && DISABLED(MKS_OLED13_128x64_FULL_GRAPHICS_CONTROLLER)


This is not needed, unless enabling MKS_OLED13_128x64_FULL_GRAPHICS_CONTROLLER were to define ULTIMAKERCONTROLLER which I don't see that it does.

I got sanity check failure, two displays defined without it.

#if defined (MKS_OLED13_128x64_FULL_GRAPHICS_CONTROLLER) #define DOGLCD #define U8GLIB_SH1106 #define REPRAP_DISCOUNT_SMART_CONTROLLER #define NEWPANEL #endif

and

#if ENABLED(PANEL_ONE) || ENABLED(U8GLIB_SH1106) #define ULTIMAKERCONTROLLER #endif

it is defined

thinkyhead · 2017-10-04T18:00:26Z

Marlin/SanityCheck.h

@@ -1146,7 +1146,7 @@ static_assert(1 >= 0
 static_assert(1 >= 0
  #if ENABLED(ULTIMAKERCONTROLLER) \
      && DISABLED(SAV_3DGLCD) && DISABLED(miniVIKI) && DISABLED(VIKI2) \
-      && DISABLED(ELB_FULL_GRAPHIC_CONTROLLER) && DISABLED(PANEL_ONE)
+      && DISABLED(ELB_FULL_GRAPHIC_CONTROLLER) && DISABLED(PANEL_ONE) && DISABLED(MKS_OLED13_128x64_FULL_GRAPHICS_CONTROLLER)
    + 1
  #endif
  #if ENABLED(REPRAP_DISCOUNT_SMART_CONTROLLER) && DISABLED(REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER)


Instead, since enabling MKS_OLED13_128x64_FULL_GRAPHICS_CONTROLLER enables REPRAP_DISCOUNT_SMART_CONTROLLER, this is where you would add the clause.

Then, below you would also add:

#if ENABLED(MKS_OLED13_128x64_FULL_GRAPHICS_CONTROLLER) + 1 #endif

OK, I see. Done

thinkyhead · 2017-10-04T18:02:42Z

Marlin/pins_RAMPS.h

+#endif
+#define LCD_PINS_RST  27
+#define LCD_PINS_DC   25
+#endif


These pins haven't been defined yet, so there's no need to #undef them. Just put your custom values in the LCD block below.

thinkyhead · 2017-10-04T18:02:53Z

Marlin/pins_RAMPS.h

@@ -129,6 +129,21 @@
  #define MAX6675_SS       66 // Do not use pin 49 as this is tied to the switch inside the SD card socket to detect if there is an SD card present
 #endif

+/*---------------MKS OLED patch_4-----------------------*/
+#if defined (MKS_OLED13_128x64_FULL_GRAPHICS_CONTROLLER)


#if ENABLED(...) is required.

thinkyhead · 2017-10-04T18:04:43Z

Marlin/pins_RAMPS.h

      #define BTN_EN1           31
      #define BTN_EN2           33
      #define BTN_ENC           35
+#endif


Indentation counts. Please strive to emulate the indentation style used in the rest of the codebase.

thinkyhead · 2017-10-04T18:05:31Z

Marlin/pins_RAMPS.h

@@ -404,4 +461,4 @@
    #endif
  #endif // NEWPANEL

-#endif // ULTRA_LCD
+ #endif // ULTRA_LCD


Remove this space.

thinkyhead · 2017-10-06T21:55:45Z

Marlin/Marlin_main.cpp

-}
-
+#if defined (MKS_12864OLED)
+  SET_OUTPUT(LCD_PINS_DC);   


Also, this is the only place this pin is used. Does this SET_OUTPUT do something special that the display needs, even though the pin is never used after this?

It was in the patch file for the display. I can remove it and see if it still works.

This pin coincides with DOGLCD_A0 — they are both assigned to pin 25. During init I guess this pin takes on a different role…?

thinkyhead · 2017-10-06T22:45:40Z

Marlin/ultralcd_impl_DOGM.h

@@ -183,9 +183,13 @@
  //U8GLIB_SSD1306_128X64 u8g(U8G_I2C_OPT_NONE | U8G_I2C_OPT_FAST);  // 8 stripes
  U8GLIB_SSD1306_128X64_2X u8g(U8G_I2C_OPT_NONE | U8G_I2C_OPT_FAST); // 4 stripes
 #elif ENABLED(U8GLIB_SH1106)
+  #if ENABLED(MKS_12864OLED)
+    U8GLIB_SH1106_128X64 u8g(23, 17, 16, 25); // SW SPI Com: SCK = 23, MOSI = 17, CS = 16, A0 = 25


What's with the hard-coded pin numbers? According to these additions to the pins_RAMPS.h file, we end up with these pins:

#if ENABLED(MKS_12864OLED) #define LCD_PINS_DC 25 #define LCD_PINS_RST 27 #else #define LCD_PINS_D5 25 #define LCD_PINS_D6 27 #endif #define LCD_PINS_RS 16 #define LCD_PINS_ENABLE 17 #define LCD_PINS_D4 23 #define LCD_PINS_D7 29

So this line might be written instead as:

U8GLIB_SH1106_128X64 u8g(LCD_PINS_D4, LCD_PINS_ENABLE, LCD_PINS_RS, LCD_PINS_DC);

Was that your intention?

I am not familiar with your functions and macros. That was the OEM recommendation. If you show me the final code, I'll try it.

ok, i understand, now. I'll try it

that worked

Works Not sure about the reset I removed in marlin_main, but the display seems to work fine without it.

…to Marlin-WIP

jmdearras · 2017-10-07T00:02:39Z

hold off on commit, issue with MKS_MINI_12864 after changing the physical order of things,

jmdearras · 2017-10-07T00:43:01Z

quitting for the night, I am suddenly getting errors on ENCODER_PULSES_PER_STEP and PER_MENU_ITEM, no clue how I broke them.

jmdearras · 2017-10-07T01:10:28Z

I closed it by mistake

thinkyhead · 2017-10-07T04:37:59Z

Marlin/ultralcd_impl_DOGM.h

@@ -183,9 +183,14 @@
  //U8GLIB_SSD1306_128X64 u8g(U8G_I2C_OPT_NONE | U8G_I2C_OPT_FAST);  // 8 stripes
  U8GLIB_SSD1306_128X64_2X u8g(U8G_I2C_OPT_NONE | U8G_I2C_OPT_FAST); // 4 stripes
 #elif ENABLED(U8GLIB_SH1106)
+  #if ENABLED(MKS_12864OLED)
+ //   U8GLIB_SH1106_128X64 u8g(23, 17, 16, 25); // SW SPI Com: SCK = 23, MOSI = 17, CS = 16, A0 = 25
+    U8GLIB_SH1106_128X64 u8g(LCD_PINS_D4, LCD_PINS_ENABLE, LCD_PINS_RS, LCD_PINS_DC);


Changed to…

// MKS 128x64 (SH1106) OLED I2C LCD U8GLIB_SH1106_128X64 u8g(DOGLCD_SCK, DOGLCD_MOSI, DOGLCD_CS, DOGLCD_A0);

thinkyhead · 2017-10-09T09:35:42Z

#7867 should now have the right NEWPANEL pins — I had forgotten to set REPRAP_DISCOUNT_SMART_CONTROLLER. If that passes, it might get into 1.1.6. Just putting release notes together now….

jmdearras · 2017-10-09T13:49:33Z

edited `REPRAP_DISCOUNT_SMART_CONTROLLER`. in sanity check ```cpp #if ENABLED(REPRAP_DISCOUNT_SMART_CONTROLLER) \ && DISABLED(REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER) \ && DISABLED(LCD_FOR_MELZI) \ && DISABLED(MAKEBOARD_MINI_2_LINE_DISPLAY_1602) && DISABLED(MKS_12864OLED) + 1 #endif ``` clean compile and it works. Jim

…

On Mon, Oct 9, 2017 at 5:36 AM, Scott Lahteine ***@***.***> wrote: #7867 <#7867> should now have the right NEWPANEL pins — I forgot to set REPRAP_DISCOUNT_SMART_ CONTROLLER. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#7824 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAksiagsD7Cokm-PpxtepyepFFNtfU2qks5sqekEgaJpZM4PrIQI> .

ScruffR · 2017-10-17T18:44:29Z

Sorry for commenting here but I just couldn't make sense of what I found on the net so far and this discussion did lighten things up a bit, but it also added some confusion 😳

I'm trying to use the stock CR-10 display with a GT2560 board to add dual extrusion to my CR-10, so I tried 1.1.6 with

#define REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER
#define U8GLIB_SH1106
#define CR10_STOCKDISPLAY

but I only get short blink and a chirp from the buzzer when switching on the board.
Do I need to rotate the 10pin header so that top left pin ends up bottom right?
Or do I need to flip the pins so that top left ends up top right?
Or both so that top left ends up bottom left?

jmdearras · 2017-10-17T19:38:49Z

if it lights up, it's correct otherwise, try reversing it. you only need to define CR10_STOCKDISPLAY. Jim

…

On Tue, Oct 17, 2017 at 2:44 PM, ScruffR ***@***.***> wrote: Sorry for commenting here but I just couldn't make sense of what I found on the net so far and this discussion did lighten things up a bit, but it also added some confusion 😳 I'm trying to use the stock CR-10 display with a GT2560 board to add dual extrusion to my CR-10, so I tried 1.1.6 with #define REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER #define U8GLIB_SH1106 #define CR10_STOCKDISPLAY but I only get short blink and a chirp from the buzzer when switching on the board. Do I need to rotate the 10pin header so that top left pin ends up bottom right? Or do I need to flip the pins so that top left ends up top right? Or both so that top left ends up bottom left? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#7824 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAksicrkRq7hgn4VL_Kc9RwpG7GNNMamks5stPWbgaJpZM4PrIQI> .

ScruffR · 2017-10-18T06:07:30Z

Thanks!
I'll comment REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER and try rotating the connector (after shaving off the polarity protection) then.

jmdearras · 2017-10-18T16:59:31Z

OK. I do not know why some board makers reverse the aux connectors, the CR-10 stock one is correct.

…

On Wed, Oct 18, 2017 at 2:07 AM, ScruffR ***@***.***> wrote: Thanks! I'll comment REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER and try rotating the connector (after shaving off the polarity protection) then. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#7824 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAksiXMgbZXGLlUbXYiJ0sytfSKRUU0zks5stZWugaJpZM4PrIQI> .

AnHardt · 2017-10-18T17:28:21Z

I do know.
It's this ingenious pdf where you cant say what's on the right and what's on the left.
http://reprap.org/mediawiki/images/7/79/LCD_connect_SCHDOC.pdf

jmdearras · 2017-10-18T17:39:23Z

pin 1 is defined by the maker of the socket. on the key side of the connector.

…

On Wed, Oct 18, 2017 at 1:28 PM, AnHardt ***@***.***> wrote: I do know. It's this ingenious pdf where you cant say what's on the right and what's on the left. http://reprap.org/mediawiki/images/7/79/LCD_connect_SCHDOC.pdf — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#7824 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAksiWQOZl-Zh7c8uN4OeBjcKfc764bWks5stjVFgaJpZM4PrIQI> .

jmdearras · 2017-10-18T17:41:01Z

[image: Inline image 1]

…

On Wed, Oct 18, 2017 at 1:39 PM, Jim DeArras ***@***.***> wrote: pin 1 is defined by the maker of the socket. on the key side of the connector. On Wed, Oct 18, 2017 at 1:28 PM, AnHardt ***@***.***> wrote: > I do know. > It's this ingenious pdf where you cant say what's on the right and what's > on the left. > http://reprap.org/mediawiki/images/7/79/LCD_connect_SCHDOC.pdf > > — > You are receiving this because you modified the open/close state. > Reply to this email directly, view it on GitHub > <#7824 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAksiWQOZl-Zh7c8uN4OeBjcKfc764bWks5stjVFgaJpZM4PrIQI> > . >

ScruffR · 2017-10-18T20:07:41Z

I've now tried with the connector rotated and now the display lights up and the buzzer chirps when keeping the encoder button pressed, but the display stays blank

Tried all combinations of

//#define REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER
#define U8GLIB_SH1106
#define CR10_STOCKDISPLAY

and

#define REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER
#define U8GLIB_SH1106
#define CR10_STOCKDISPLAY

and

BOARD_GT2560_REV_A

and

BOARD_GT2560_REV_A_PLUS

(it's a board marked as A+)

The display is connected to the 10 pin header marked LCD (I guess this is EXT2 - not AUX)

BTW, gcode M300 does play a sound as intended.

These are my configs for 1.1.6

Configuration.zip

ScruffR · 2017-10-19T12:42:26Z

I have now flashed some test sketch onty my GT2560 A+ board and realised that the pinout on the header must be completely off.

With a u8glib test sketch I figured that the CR10_STOCKDISPLAY actually uses only three pins (SPI mode).
On the GT2560 A+ the respective pins are

// CR10_STOCKDISPLAY on GT2560 | name on DISPLAY | pin# on GT2560 | function
#define E  21                 // E               | 21             | SCLK  (SPI Clock) 
#define RW  6                 // RW              |  6             | MOSI  (Master Out Slave In)
#define RS  5                 // RS              |  5             | CS/SS (Chip/Slave Select)

(this is with the 10pin header rotated)

ScruffR · 2017-10-19T13:48:04Z

I haven't come round yet to investigate the SD pinout but this is how the display and rotary encoder need to be set up for CR10_STOCKDISPLAY on GT2560 A/A+

pins_GT2560_REV_A.h

#if ENABLED(ULTRA_LCD)

  #define BEEPER_PIN       18
  #if ENABLED(NEWPANEL)
    // ************* ScruffR ************* 
    #if ENABLED(CR10_STOCKDISPLAY) 
      #define LCD_PINS_RS      5
      #define LCD_PINS_ENABLE  6
      #define LCD_PINS_D4     21
      #define LCD_PINS_D5     -1
      #define LCD_PINS_D6     -1
      #define LCD_PINS_D7     -1

      // Buttons are directly attached
      #define BTN_EN1         17
      #define BTN_EN2         16
      #define BTN_ENC         19
    // ************* ScruffR ************* 
    #else
      #define LCD_PINS_RS     20
      #define LCD_PINS_ENABLE 17
      #define LCD_PINS_D4     16
      #define LCD_PINS_D5     21
      #define LCD_PINS_D6      5
      #define LCD_PINS_D7      6

      // Buttons are directly attached
      #define BTN_EN1         42
      #define BTN_EN2         40
      #define BTN_ENC         19
    #endif

    #define SD_DETECT_PIN     38

  #else // !NEWPANEL

    #define SHIFT_CLK      38
    #define SHIFT_LD       42
    #define SHIFT_OUT      40
    #define SHIFT_EN       17

    #define LCD_PINS_RS      5
    #define LCD_PINS_ENABLE  6
    #define LCD_PINS_D4     21
    #define LCD_PINS_D5      0
    #define LCD_PINS_D6      0
    #define LCD_PINS_D7      0

    #define SD_DETECT_PIN  -1

  #endif // !NEWPANEL

#endif // ULTRA_LCD

jmdearras and others added 7 commits September 13, 2017 17:20

add 2 displays

2076b54

original CR-10 and MKS Minidisplay

"Standard" Display

37eb88e

Edit CR10_stockdisplay NOPs

2756068

Added Displays cleanup

dd72bfd

Added 2 line display

4dd63f4

More cleanup

075e393

The default board needs to be RAMPS_EFB

f44758c

fiveangle reviewed Oct 3, 2017

View reviewed changes

thinkyhead reviewed Oct 4, 2017

View reviewed changes

thinkyhead reviewed Oct 6, 2017

View reviewed changes

thinkyhead mentioned this pull request Oct 6, 2017

[1.1.x] Add support for 4 new LCDs #7867

Merged

thinkyhead reviewed Oct 6, 2017

View reviewed changes

jmdearras added 2 commits October 6, 2017 19:08

MKS_12864OLED cleanup

faa1db8

Works Not sure about the reset I removed in marlin_main, but the display seems to work fine without it.

Merge branch 'Marlin-WIP' of https://github.com/jmdearras/Marlin-1 in…

2b37c11

…to Marlin-WIP

jmdearras closed this Oct 7, 2017

encoder stuff??

29e35d8

jmdearras reopened this Oct 7, 2017

MarlinFirmware deleted a comment from jmdearras Oct 7, 2017

thinkyhead added the S: Superseded label Oct 7, 2017

thinkyhead reviewed Oct 7, 2017

View reviewed changes

update all

77b78e1

thinkyhead mentioned this pull request Oct 9, 2017

[2.0.x] Add support for 4 new LCDs #7914

Merged

thinkyhead closed this Oct 9, 2017

thinkyhead mentioned this pull request Sep 5, 2021

Change ST9720 delay settings priorities #22713

Merged

[1.1.x] Support some more LCD types #7824

[1.1.x] Support some more LCD types #7824

Conversation

jmdearras commented Oct 2, 2017

Roxy-3D commented Oct 2, 2017

Choose a reason for hiding this comment

fiveangle Oct 4, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fiveangle left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fiveangle Oct 3, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmdearras commented Oct 3, 2017 via email

jmdearras commented Oct 3, 2017 via email

jmdearras commented Oct 3, 2017 via email

fiveangle commented Oct 3, 2017 • edited Loading

jmdearras commented Oct 4, 2017 via email

jmdearras commented Oct 4, 2017 via email

Tannoo commented Oct 4, 2017

fiveangle commented Oct 4, 2017 • edited Loading

jmdearras commented Oct 4, 2017 via email

fiveangle commented Oct 4, 2017 • edited Loading

thinkyhead commented Oct 4, 2017 • edited Loading

thinkyhead commented Oct 4, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmdearras Oct 5, 2017 • edited by thinkyhead Loading

Choose a reason for hiding this comment

thinkyhead Oct 4, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thinkyhead Oct 4, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thinkyhead Oct 4, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thinkyhead Oct 6, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmdearras commented Oct 7, 2017

jmdearras commented Oct 7, 2017

jmdearras commented Oct 7, 2017

Choose a reason for hiding this comment

thinkyhead commented Oct 9, 2017 • edited Loading

jmdearras commented Oct 9, 2017 via email • edited by thinkyhead Loading

ScruffR commented Oct 17, 2017

jmdearras commented Oct 17, 2017 via email

ScruffR commented Oct 18, 2017

jmdearras commented Oct 18, 2017 via email

AnHardt commented Oct 18, 2017

jmdearras commented Oct 18, 2017 via email

jmdearras commented Oct 18, 2017 via email

ScruffR commented Oct 18, 2017 • edited Loading

ScruffR commented Oct 19, 2017

ScruffR commented Oct 19, 2017 • edited Loading

fiveangle Oct 4, 2017 •

edited

Loading

fiveangle Oct 3, 2017 •

edited

Loading

fiveangle commented Oct 3, 2017 •

edited

Loading

fiveangle commented Oct 4, 2017 •

edited

Loading

fiveangle commented Oct 4, 2017 •

edited

Loading

thinkyhead commented Oct 4, 2017 •

edited

Loading

jmdearras Oct 5, 2017 •

edited by thinkyhead

Loading

thinkyhead Oct 4, 2017 •

edited

Loading

thinkyhead Oct 4, 2017 •

edited

Loading

thinkyhead Oct 4, 2017 •

edited

Loading

thinkyhead Oct 6, 2017 •

edited

Loading

thinkyhead commented Oct 9, 2017 •

edited

Loading

jmdearras commented Oct 9, 2017 via email •

edited by thinkyhead

Loading

ScruffR commented Oct 18, 2017 •

edited

Loading

ScruffR commented Oct 19, 2017 •

edited

Loading