-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Host Keepalive configurable timeout with 2s default #3414
Host Keepalive configurable timeout with 2s default #3414
Conversation
8aa2cc3
to
24c83b6
Compare
24c83b6
to
b557505
Compare
@@ -36,10 +36,10 @@ | |||
* | |||
*/ | |||
|
|||
#define EEPROM_VERSION "V23" | |||
#define EEPROM_VERSION "V24" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be really stored on the EEPROM ?
Despite all the philosophical discussion about this feature it's not that important to change & remember the setting value at runtime, it's more of thing to be "set and forget" at compile time IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbrazio The reason this setting is was being added to EEPROM is because it is a configurable setting that can be overridden. Usually, when there's a setting like this where the Configuration value is only supplying a default for something which can be changed later, we also save it in EEPROM and include it in the M503
output. (In any case, this is why the setting is called DEFAULT_KEEPALIVE_INTERVAL
— to indicate it can be changed as a variable.)
Anyway, if it doesn't seem too vital to save this in EEPROM, then it's no big deal for me to remove that part of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the possibility to tweak during runtime the value (this was a great idea), but who may tweak this ? Developers and Host software which IMO is highly "session" dependent thus not really requiring to be remembered between power cycles.
f013f0e
to
4adf226
Compare
4adf226
to
e0b0d1e
Compare
This PR makes it possible to configure the Host Keepalive timeout, and also to enable/disable the host Keepalive altogether. The following changes are made:
DEFAULT_KEEPALIVE_INTERVAL
setting with a default value of2
host_keepalive_interval
variable to replace hardcoded intervalM113
to get or sethost_keepalive_interval
Addhost_keepalive_interval
to EEPROM, bumping the version to "V24"