Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The printrbot/printrboard fork of marlin has working LCD support and fixed some some fastio / teensy pin issues not in trunk. This PR includes those changes (commits listed below), but not as a proper merge commit.
I've spent enough time today fucking with finding the commits that fix the problems I was having. Please let me know how to go about making these "real" merge commits or how I can help you merge these (or more?) changes from the printrbot branch.
The commits fixing the LCD problems I had are listed below:
Commit: 1f17c43 [1f17c43]
Parents: 5d58fe0
Author: Laine Walker-Avina [email protected]
Date: Thursday, April 18, 2013 10:55:16 PM
Commit Date: Saturday, January 18, 2014 2:09:00 PM
Marlin_main: Disable JTAG in setup() if DISABLE_JTAG is defined
Allows use of JTAG pins as IO
Commit: a2b97c3 [a2b97c3]
Parents: cc992f0
Author: Laine Walker-Avina [email protected]
Date: Thursday, July 11, 2013 11:39:12 AM
Commit Date: Sunday, January 19, 2014 3:42:04 PM
Printrboard: Disable JTAG
Commit: ebe5f4b [ebe5f4b]
Parents: a2b97c3
Author: Laine Walker-Avina [email protected]
Date: Wednesday, July 24, 2013 10:20:47 PM
Commit Date: Sunday, January 19, 2014 3:42:04 PM
Fix fan pin from conflicting with other pins on Teensyduino based platforms
Commit: b02e8bd [b02e8bd]
Parents: ebe5f4b
Author: Laine Walker-Avina [email protected]
Date: Wednesday, July 24, 2013 10:25:42 PM
Commit Date: Sunday, January 19, 2014 3:42:04 PM
Fix pins for Printrboard
Commit: cc41b44 [cc41b44]
Parents: 875a39c
Author: Laine Walker-Avina [email protected]
Date: Friday, August 2, 2013 2:37:32 PM
Commit Date: Sunday, January 19, 2014 3:42:04 PM
ultralcd: Use SET_{OUTPUT|INPUT}() instead of pinMode() to set pin direction