Fix TMC communication error on S6 V2 #27595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix a bug introduced by 91e4811. Previous S6 boards have distinct pins for TX and RX while V2 use the same pin. Including previous board pin header cause a definition of RX that is conflicting also with X enable
|
To be explicit: Problem is just on Y axis RX signal |
|
Good to have this fix ahead of the next beta! I will rebuild any affected binaries ahead of the dump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix a bug introduced by 91e4811.
Previous S6 boards have distinct pins for TX and RX while V2 use the same pin.