-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚸 Fix extra Z raises #27395
🚸 Fix extra Z raises #27395
Conversation
14565bd
to
b452169
Compare
b452169
to
61fc6a1
Compare
after this change (I think although my last marlin compile was few weeks ago) I had to define Z_AFTER_HOMING to 0 or otherwise the MPCNC would move to z of 5 after homing. In Configuration.h the default comment is:
not sure why my machine moved to 5 and not 10 which seems to be the default value? |
@thijstriemstra: The reason your Z height after homing was
Enable & set your The conditionals are a bit spread out, but hopefully that clears things up. |
thanks for your excellent explanation @thisiskeithb. I previously had this defined:
Which "stopped working" and the |
Before homing we don't know where Z is, but on most machines we know it's above 0. And once Z has been raised we can be pretty certain it's at or above
current_position.z
.This PR adds a flag to indicate that Z has been powered on and its Z position should be trusted to be at or above
current_position.z
. If "Z" is disabled on a machine that has a falling toolhead then the flag is cleared when the Z stepper is powered off.