27249 Followup, re order preflight-checks.py #27285
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #27249
As it is currently preflight-checks.py does not correctly detect and fix "#if BOTH()" or "#if EITHER()"
At present it does this
The cause is preflight-checks attempts to load all MARLIN_FEATURES before checking for the invalid MACROS
Reordering preflight-checks.py and it now warns and updated the macro as expected.
Requirements
Old "#if BOTH()" or "#if EITHER()" in Configuration files.
Benefits
Works as expected
Related Issues
#27249