Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ender 2 Pro LCD_PINS_RS = PB15 #27074

Merged
merged 3 commits into from
May 17, 2024

Conversation

jam-berg
Copy link
Contributor

@jam-berg jam-berg commented May 9, 2024

added missing LCD_PINS_RS for Ender 2 Pro BOARD_CREALITY_ENDER2P_V24S4 and set to PB15

I tested it on the Ender 2 Pro and the LCD is now working. Before, just de backlight of the LCD was turned on but no image.

Description

This Pull Request defines the PB15 Pin, that is used as EXP_07 and then assigned to LCD_PINS_RS.
This is for the BOARD_CREALITY_ENDER2P_V24S4. The information was extracted from the Creality repository https://github.com/CrealityOfficial/Ender-2-Pro/tree/MCU_HDSC and tested on the Ender 2 Pro

Requirements

  • CR-10 LCD
  • BOARD_CREALITY_ENDER2P_V24S4

Benefits

This pull request makes the LCD of the Ender 2 Pro functional.

Configurations

Default Config files of the Marlin Config repository for this board.

@thisiskeithb
Copy link
Member

PB15 was removed on purpose in #26908 so perhaps there is different LCD hardware in use / different requirements?

@thinkyhead
Copy link
Member

The version referred to in that PR was CR-FDM-V2.4.S4.170 …. Do you have a board with the identical number or is there some difference?

@thinkyhead thinkyhead changed the title added missing LCD_PINS_RS for Ender 2 Pro BOARD_CREALITY_ENDER2P_V24S4 and set to PB15 Ender 2 Pro LCD_PINS_RS = PB15 May 9, 2024
@ellensp
Copy link
Contributor

ellensp commented May 10, 2024

back of the physical board, note the NCC pin

and here is the front for the board number CR-FDM-v2.4.S4.170

@shadow578
Copy link
Contributor

Hi there,

chipping in since this PR originated from a issue created on my dev repo shadow578#61.

from what i can tell, #26903 was caused by redefinition of PC1 as both KILL_PIN and X_STEP_PIN, and not by PB15 being assigned to the LCD.

the removal of EXP1_07_PIN = PB15 was done according to the pinout at https://gist.github.com/SteveGotthardt/33bdef27d1430f62b4fee5d723d0cde9, which states that EXP1_07_PIN is "NCC" = No Connection.
but perhaps this isn't right, and "NCC" is "(Negative) Chip Control" (= NSS).

#define SPI_NSS PB15 // SPI3_NSS

So maybe this isn't a different board revision, but the same revision and the pinout provided by @SteveGotthardt is incorrect.

@ellensp
Copy link
Contributor

ellensp commented May 10, 2024

Need someone with the actual board to check it. Since the information available is in conflict.

But im inclined to think that n/c is not correct and ncc meant something else

@jam-berg
Copy link
Contributor Author

jam-berg commented May 10, 2024

@jam-berg
Copy link
Contributor Author

And the front of my board:
BoardEnder2Pro

@ellensp
Copy link
Contributor

ellensp commented May 14, 2024

I asked SteveGotthardt to verify this pin on his board.
He has confirmed that pin EXP1_07_PIN (NCC) should be PB15

@thinkyhead
please revert the ENDER2_PRO_REV_QQQ variant code and add this change

@thinkyhead thinkyhead merged commit ef0bd97 into MarlinFirmware:bugfix-2.1.x May 17, 2024
61 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants