fix buzzer sometimes beep continuously when SPEAKER disabled #26278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When SPEAKER disabled and set ui.sound_on = false while beeping, it is necessary to continue executing tick() to turn off beep.
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
from
c624e13 to
e6f1b07
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
2 times, most recently
from
9c65146 to
4f65466
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
from
c792921 to
37fb26b
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
3 times, most recently
from
37d77d6 to
aa44542
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When SPEAKER disabled, Buzzer.tick() needs to be executed to stop beeping
Requirements
LCD, Buzzer
Benefits
Fixed the issue of continuous beeping when turning off sound from the LCD menu
Fixed continuous beeping when PID autotune from the LCD menu
Configurations
//#define SPEAKER
#define SOUND_MENU_ITEM
#define PID_AUTOTUNE_MENU
Related Issues
#23556