-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build script for upcoming PIO 4.4 #19034
Fix build script for upcoming PIO 4.4 #19034
Conversation
How did you learn about this change? It looks like there are some other fails as well. |
Ivan told us that PIO was changing their package spec parser (in the comments of #18699). This PR do what he told us to do: use the new package spec parser. And keep compatibility with the old PIO too. I checked, and now the CI is failing because missing packages in PIO registry... Now I don't know if is a pio bug, or if is because Ivan is releasing it right now, or if the package is missing... |
|
I think we need take a break of using pio dev in CI, and trying to figure out what will break in PIO 4.4. |
It seems that other things are generally broken. When I try to do the native sim build with PIO Core 4.3.4 I get all kinds of new errors about missing standard headers. And if I try to build the native sim with 4.4.0a8 with the changes in this PR I get a weird error from |
Seem he pushed the new PIO to dev branch, but not updated the PIO registry yet. Or we are just in the middle of a PIO big release... |
Until that is sorted, I will revert back to |
Sorry, we upload this package to the registry. Now, everything should work.
Thanks! |
Description
CI are using PIO 4.4 and is breaking because a core class was removed. This PR updates the dependency script to work with both PIO versions.
I think this PR should be part of the upcoming 2.0.6.1, as PIO could release their new version anytime.
Benefits
Fixes CI
Compatibility with PIO >= 4.4 and < 4.4
Related Issues
#18699