STM32F1: secure the servo code + M280 detach #14085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tpruvot
commented
May 22, 2019
tpruvot
commented
- A pin without timer would crash with tdev = nullptr
- Allow M280 P0 S-1 to stop the pwm timer
- ServoCount is not static, so it should be initialised to 0
- A pin without timer would crash with tdev = nullptr - Allow M280 P0 S-1 to stop the pwm timer
xC0000005
reviewed
May 22, 2019
| @@ -68,23 +68,25 @@ libServo::libServo() { | |||
|
|
|||
| bool libServo::attach(const int32_t pin, const int32_t minAngle, const int32_t maxAngle) { | |||
| if (this->servoIndex >= MAX_SERVOS) return false; | |||
| if (!PWM_PIN(pin)) return false; | |||
There was a problem hiding this comment.
This seems like something we should catch at compile time. Is that not possible?
There was a problem hiding this comment.
actually i changed that to do tpruvot@2ec402e
There was a problem hiding this comment.
If the pin is constant at compile time, it may be able to evaluate PWM_PIN at compile time. Note that HALs are free to define PWM_PIN as a function call, and then it would (perhaps) never be evaluated at compile time. Some HALs already define it with a bit of logic, in which cases it will probably not be evaluated at compile time.
ozgunawesome
pushed a commit
to ozgunawesome/Marlin
that referenced
this pull request
May 29, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.