Skip to content

Commit

Permalink
🎨 Use ExtUI API where applicable
Browse files Browse the repository at this point in the history
  • Loading branch information
Desuuuu authored and thinkyhead committed Oct 3, 2021
1 parent 209e5c2 commit fcbd99d
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 25 deletions.
2 changes: 1 addition & 1 deletion Marlin/Configuration.h
Original file line number Diff line number Diff line change
Expand Up @@ -2566,7 +2566,7 @@
// - Copy the downloaded DWIN_SET folder to the SD card.
//
// RELOADED (T5UID1)
// - Download https://github.com/Desuuuu/DGUS-reloaded
// - Download https://github.com/Desuuuu/DGUS-reloaded/releases
// - Copy the downloaded DWIN_SET folder to the SD card.
//
//#define DGUS_LCD_UI_ORIGIN
Expand Down
21 changes: 6 additions & 15 deletions Marlin/src/lcd/extui/dgus_reloaded/DGUSRxHandler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,13 @@ void DGUSRxHandler::ScreenChange(DGUS_VP &vp, void *data_ptr) {
}

if (vp.addr == DGUS_Addr::SCREENCHANGE_Idle
&& (printingIsActive() || printingIsPaused())) {
&& (ExtUI::isPrinting() || ExtUI::isPrintingPaused())) {
dgus_screen_handler.SetStatusMessagePGM(PSTR("Impossible while printing"));
return;
}

if (vp.addr == DGUS_Addr::SCREENCHANGE_Printing
&& (!printingIsActive() && !printingIsPaused())) {
&& (!ExtUI::isPrinting() && !ExtUI::isPrintingPaused())) {
dgus_screen_handler.SetStatusMessagePGM(PSTR("Impossible while idle"));
return;
}
Expand Down Expand Up @@ -166,7 +166,7 @@ void DGUSRxHandler::PrintAbort(DGUS_VP &vp, void *data_ptr) {
return;
}

if (!printingIsActive() && !printingIsPaused()) {
if (!ExtUI::isPrinting() && !ExtUI::isPrintingPaused()) {
dgus_screen_handler.TriggerFullUpdate();
return;
}
Expand All @@ -183,7 +183,7 @@ void DGUSRxHandler::PrintPause(DGUS_VP &vp, void *data_ptr) {
return;
}

if (!printingIsActive()) {
if (!ExtUI::isPrinting()) {
dgus_screen_handler.TriggerFullUpdate();
return;
}
Expand All @@ -200,7 +200,7 @@ void DGUSRxHandler::PrintResume(DGUS_VP &vp, void *data_ptr) {
return;
}

if (!printingIsPaused()) {
if (!ExtUI::isPrintingPaused()) {
dgus_screen_handler.TriggerFullUpdate();
return;
}
Expand Down Expand Up @@ -984,20 +984,11 @@ void DGUSRxHandler::WaitAbort(DGUS_VP &vp, void *data_ptr) {
return;
}

if (!printingIsPaused()
#if ENABLED(ADVANCED_PAUSE_FEATURE)
|| !did_pause_print
#endif
) {
if (!ExtUI::isPrintingPaused()) {
dgus_screen_handler.TriggerFullUpdate();
return;
}

#if ENABLED(ADVANCED_PAUSE_FEATURE)
did_pause_print = 0;
#endif

ExtUI::setUserConfirmed();
ExtUI::stopPrint();

dgus_screen_handler.TriggerFullUpdate();
Expand Down
4 changes: 2 additions & 2 deletions Marlin/src/lcd/extui/dgus_reloaded/DGUSSetupHandler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
#endif

bool DGUSSetupHandler::PrintStatus() {
if (printingIsActive() || printingIsPaused()) {
if (ExtUI::isPrinting() || ExtUI::isPrintingPaused()) {
return true;
}

Expand All @@ -56,7 +56,7 @@ bool DGUSSetupHandler::PrintStatus() {
}

bool DGUSSetupHandler::PrintAdjust() {
if (printingIsActive() || printingIsPaused()) {
if (ExtUI::isPrinting() || ExtUI::isPrintingPaused()) {
return true;
}

Expand Down
10 changes: 3 additions & 7 deletions Marlin/src/lcd/extui/dgus_reloaded/DGUSTxHandler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ void DGUSTxHandler::Percent(DGUS_VP &vp) {
void DGUSTxHandler::StatusIcons(DGUS_VP &vp) {
uint16_t icons = 0;

if (printingIsActive()) {
if (ExtUI::isPrinting()) {
icons |= (uint16_t)DGUS_Data::StatusIcon::PAUSE;

dgus_display.EnableControl(DGUS_Screen::PRINT_STATUS,
Expand All @@ -227,7 +227,7 @@ void DGUSTxHandler::StatusIcons(DGUS_VP &vp) {
DGUS_Control::PAUSE);
}

if (printingIsPaused()) {
if (ExtUI::isPrintingPaused()) {
icons |= (uint16_t)DGUS_Data::StatusIcon::RESUME;

dgus_display.EnableControl(DGUS_Screen::PRINT_STATUS,
Expand Down Expand Up @@ -561,11 +561,7 @@ void DGUSTxHandler::FilamentUsed(DGUS_VP &vp) {
void DGUSTxHandler::WaitIcons(DGUS_VP &vp) {
uint16_t icons = 0;

if (printingIsPaused()
#if ENABLED(ADVANCED_PAUSE_FEATURE)
&& did_pause_print
#endif
) {
if (ExtUI::isPrintingPaused()) {
icons |= (uint16_t)DGUS_Data::WaitIcon::ABORT;

dgus_display.EnableControl(DGUS_Screen::WAIT,
Expand Down

0 comments on commit fcbd99d

Please sign in to comment.