Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule/no embedded keyword arguments #1120

Merged

Conversation

Lakitna
Copy link
Contributor

@Lakitna Lakitna commented Oct 10, 2024

Closes #1118

Adds new community rule no-embedded-keyword-arguments

@Lakitna Lakitna requested review from bhirsz and mnojek as code owners October 10, 2024 16:09
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.96%. Comparing base (f62508c) to head (c590e6c).
Report is 34 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1120      +/-   ##
==========================================
- Coverage   97.02%   96.96%   -0.07%     
==========================================
  Files          37       39       +2     
  Lines        4670     5002     +332     
==========================================
+ Hits         4531     4850     +319     
- Misses        139      152      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bhirsz bhirsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, Thanks!

@bhirsz bhirsz merged commit d1507db into MarketSquare:master Oct 14, 2024
13 checks passed
@bhirsz
Copy link
Member

bhirsz commented Oct 14, 2024

I will try to release it soon, I just need to look if I can add some additional change/fix in the same release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Rule] No embedded keyword arguments
2 participants