Fix task section detection (#1075)

MarketSquare · May 6, 2024 · 95bd18b · 95bd18b
1 parent 28e028e
commit 95bd18b
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 3 deletions.
diff --git a/docs/releasenotes/unreleased/fixes.1.rst b/docs/releasenotes/unreleased/fixes.1.rst
@@ -0,0 +1,7 @@
+Task section not recognized for mixed-task-test-settings rule (#1074)
+----------------------------------------------------------------------
+
+If last section of the file wasn't Tasks section, Robocop assumed that file contains only Test Cases section. This
+caused W0326 ``mixed-task-test-settings`` to be issued with incorrect message.
+
+Thanks @MrBIN89 for finding the issue.
diff --git a/robocop/checkers/naming.py b/robocop/checkers/naming.py
@@ -877,8 +877,9 @@ def visit_File(self, node):  # noqa
                     ROBOT_VERSION.major >= 6 and section.header.type == Token.TASK_HEADER
                 ):
                     self.task_section = True
-            else:
-                self.task_section = False
+                    break
+        else:
+            self.task_section = False
         super().visit_File(node)
 
     def visit_Setup(self, node):  # noqa

diff --git a/tests/atest/rules/naming/mixed_task_test_settings/mixed_tasks.robot b/tests/atest/rules/naming/mixed_task_test_settings/mixed_tasks.robot
@@ -7,6 +7,15 @@ Task Tags       tag
 Documentation   some docs
 
 
+*** Variables ***
+${variable}    value
+
+
+
 *** Tasks ***
 Some Task
     No Operation
+
+*** Keywords ***
+Some Keyword
+    No Operation
diff --git a/tests/atest/rules/naming/mixed_task_test_settings/mixed_tests.robot b/tests/atest/rules/naming/mixed_task_test_settings/mixed_tests.robot
@@ -7,6 +7,10 @@ Task Tags       tag
 Documentation   some docs
 
 
+*** Variables ***
+${variable}    value
+
+
 *** Test Cases ***
 Some Task
     No Operation
diff --git a/tests/atest/rules/naming/mixed_task_test_settings/test_rule.py b/tests/atest/rules/naming/mixed_task_test_settings/test_rule.py
@@ -13,7 +13,7 @@ def test_rule_rf6(self):
                 "golden_test.robot",
             ],
             expected_file="expected_output_rf6.txt",
-            target_version="==6.*",
+            target_version=">=6",
         )
 
     def test_rule(self):