Merge cli repo for better dependency management #139

[acjh]

Resolves #139

I did git merge cli --allow-unrelated-histories to preserve histories from both repos.
As such, there are 200+ commits. Here are the newest commits that are specific to this PR:

• df3a62b Move core library into lib/markbind
• 7402e2a Update eslintignore for lib/markdown-it/*
• 59830af Merge branch 'cli'
• 83b373c Restore eslint-plugin-lodash
• 9962681 Use local markbind (overwritten by force-push)
• c36f595 Use local markbind

---

1. To test this, cd to the markbind folder, pull this branch, and then run (sudo) npm link.
2. We can publish markbind-cli from the root, and publish markbind core from ./lib/markbind.
3. Caveat: When running npm version, tagging is now committed for cli but not the core library.
   • This means that if you push that commit, the markbind-cli tag will be added to this repo.
   • Maybe create a version-specific branch that is only pushed to MarkBind/markbind-cli repo.
   • Committing and tagging for the core library has to be done manually (smallest issue here).
   • ⚠ Care must be taken that maintainers with write access do not "Push all tags" in SourceTree:
     

[acjh]

It should be easy to merge changes from MarkBind/markbind-cli when existing PRs there are merged.

[acjh]

If this PR is merged, I can release [email protected] from this merged repo tomorrow (or Monday).

[acjh]

3. Caveat: When running npm version, tagging is now committed for cli but not the core library.
   • ...

Or we could sync the release versions, and then we can use the same Milestone and tags for both!

[nicholaschuayunzhi]

To clarify

To test this, cd to the markbind folder, pull this branch, and then run (sudo) npm link

If we're using local markbind in c36f595 we don't have to run the $ npm link command right?

[acjh]

npm link binds the markbind command and the global node_modules/markbind-cli to that folder.

You should have run it before, but that was the unmerged markbind-cli folder:
https://github.com/MarkBind/markbind-cli/wiki/Developer-Guide#development

3. To make sure you are using the cloned CLI program in your own terminal/console, in the cloned CLI repo, run

   $ npm link
   

[Gisonrg]

Thanks @acjh for the efforts!!! The merge is not easy 👏

npm version has a command flag which disallow auto commit tag, we could enforce that by automation (could use npm scripts) and well written release guide.

Also we need to migrate the Wiki page, which works similar to change a git remote address (Wikis are just a repo).

[Gisonrg]

Migration looks good to me. But make sure we test:

1. All functions are working, including publish.
2. Try publish the markbind-core in the merged repo, after that try install it (using a new node project) to see if it could correctly identify the package.

Also might need to mark the markbind-cli repo as deprecated (remove the code and update the README).

[Gisonrg]

Should change this to MarkBind/markbind

[acjh]

Published [email protected] and tested like this:

$ cd ~/Desktop
$ mkdir tmp
$ cd tmp
$ npm init
$ # Press enter 10 times.
$ npm install [email protected]
$ echo "const MarkBind = require('markbind');" > index.js
$ echo "console.log(new MarkBind());" >> index.js
$ node index.js

Output:

Parser {
  _options: {},
  _onError: [Function: bound consoleCall],
  _fileCache: {},
  dynamicIncludeSrc: [],
  staticIncludeSrc: [],
  boilerplateIncludeSrc: [],
  missingIncludeSrc: [] }

[acjh]

Merge worked fine.

[acjh]

Also we need to migrate the Wiki page, which works similar to change a git remote address (Wikis are just a repo).

I was thinking of going straight to #135. Easier to track future changes and PRs.

Also might need to mark the markbind-cli repo as deprecated (remove the code and update the README).

I updated the README. I'll remove the code when the remaining PRs are closed.

[acjh]

@Gisonrg Can you activate Travis on this repo? 🙈