fix(auto-updater): Race condition during Application Quit

Close electron-userland#2745
MariaDima · Mar 26, 2018 · 3b4800b · 3b4800b
1 parent 5f0dd86
commit 3b4800b
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/packages/electron-updater/src/BaseUpdater.ts b/packages/electron-updater/src/BaseUpdater.ts
@@ -20,8 +20,9 @@ export abstract class BaseUpdater extends AppUpdater {
         if (this.app.quit !== undefined) {
           this.app.quit()
         }
-        this.quitAndInstallCalled = false
       })
+    } else {
+      this.quitAndInstallCalled = false
     }
   }
 
@@ -136,6 +137,8 @@ export abstract class BaseUpdater extends AppUpdater {
       if (!this.quitAndInstallCalled) {
         this._logger.info("Auto install update on quit")
         await this.install(true, false)
+      } else {
+        this._logger.info("Update installer has already been triggered. Quitting application.")
       }
     })
   }