Skip to content

Commit

Permalink
Use com.apple.* bundle identifier FFS
Browse files Browse the repository at this point in the history
Restores support for avi files and for less common codecs in .mov, .ts and
.m2ts files. Fixes #86 #91

Inspired by whomwah/qlstephen#135
  • Loading branch information
Marginal committed Nov 13, 2022
1 parent d6fc176 commit 8e392b1
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 9 deletions.
12 changes: 6 additions & 6 deletions QLVideo.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -913,7 +913,7 @@
GCC_PRECOMPILE_PREFIX_HEADER = YES;
INFOPLIST_FILE = app/Info.plist;
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Application Support";
PRODUCT_BUNDLE_IDENTIFIER = uk.org.marginal.qlvideo;
PRODUCT_BUNDLE_IDENTIFIER = com.apple.uk.org.marginal.qlvideo;
PRODUCT_NAME = "$(TARGET_NAME)";
WRAPPER_EXTENSION = app;
};
Expand All @@ -929,7 +929,7 @@
GCC_PRECOMPILE_PREFIX_HEADER = YES;
INFOPLIST_FILE = app/Info.plist;
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Application Support";
PRODUCT_BUNDLE_IDENTIFIER = uk.org.marginal.qlvideo;
PRODUCT_BUNDLE_IDENTIFIER = com.apple.uk.uk.org.marginal.qlvideo;
PRODUCT_NAME = "$(TARGET_NAME)";
WRAPPER_EXTENSION = app;
};
Expand All @@ -943,7 +943,7 @@
INFOPLIST_FILE = qlgenerator/Info.plist;
INSTALL_PATH = /Library/QuickLook;
LD_RUNPATH_SEARCH_PATHS = "";
PRODUCT_BUNDLE_IDENTIFIER = uk.org.marginal.qlvideo.qlgenerator;
PRODUCT_BUNDLE_IDENTIFIER = com.apple.uk.org.marginal.qlvideo.qlgenerator;
PRODUCT_NAME = Video;
WRAPPER_EXTENSION = qlgenerator;
};
Expand All @@ -957,7 +957,7 @@
INFOPLIST_FILE = qlgenerator/Info.plist;
INSTALL_PATH = /Library/QuickLook;
LD_RUNPATH_SEARCH_PATHS = "";
PRODUCT_BUNDLE_IDENTIFIER = uk.org.marginal.qlvideo.qlgenerator;
PRODUCT_BUNDLE_IDENTIFIER = com.apple.uk.org.marginal.qlvideo.qlgenerator;
PRODUCT_NAME = Video;
WRAPPER_EXTENSION = qlgenerator;
};
Expand Down Expand Up @@ -1085,7 +1085,7 @@
INFOPLIST_FILE = mdimporter/Info.plist;
INSTALL_PATH = "${LOCAL_LIBRARY_DIR}/Spotlight";
LIBRARY_STYLE = BUNDLE;
PRODUCT_BUNDLE_IDENTIFIER = uk.org.marginal.qlvideo.mdimporter;
PRODUCT_BUNDLE_IDENTIFIER = com.apple.uk.org.marginal.qlvideo.mdimporter;
PRODUCT_NAME = Video;
WRAPPER_EXTENSION = mdimporter;
};
Expand All @@ -1099,7 +1099,7 @@
INFOPLIST_FILE = mdimporter/Info.plist;
INSTALL_PATH = "${LOCAL_LIBRARY_DIR}/Spotlight";
LIBRARY_STYLE = BUNDLE;
PRODUCT_BUNDLE_IDENTIFIER = uk.org.marginal.qlvideo.mdimporter;
PRODUCT_BUNDLE_IDENTIFIER = com.apple.uk.org.marginal.qlvideo.mdimporter;
PRODUCT_NAME = Video;
WRAPPER_EXTENSION = mdimporter;
};
Expand Down
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ Screenshots

Limitations
-----------
* QuickLook under Catalina can't preview most `.avi` files and some `.dv`, `.mov`, `.mp4`, `.m4v` and `.ts` files, but won't let this plugin preview them either.
* QuickLook under Mavericks, Yosemite and El Capitan struggles with `.mp4` files. In particular, it won't let this plugin preview `.mp4` files that it can't handle itself (e.g. containing H.265 video) or you that you have asked it not to handle via the `SnapshotAlways` [setting](#customisation). Rename your `.mp4` files as `.m4v`, or use another container for H.265 content - e.g. [Matroska](http://www.matroska.org/).
* The QuickLook "Preview" function displays one or more static snapshots of "non-native" video files. You'll need a media player app (e.g. [VLC](http://www.videolan.org/vlc/) or [MPlayerX](http://mplayerx.org/)) to play these files.
* Interlaced content is sometimes not de-interlaced in QuickLook thumbnails and previews.
* Requires macOS 10.13 "High Sierra" or later on a 2013 or newer Mac.
Expand Down
2 changes: 1 addition & 1 deletion qlgenerator/GeneratePreviewForURL.m
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ OSStatus GeneratePreviewForURL(void *thisInterface, QLPreviewRequestRef preview,
if (QLPreviewRequestIsCancelled(preview)) return kQLReturnNoError;
CFBundleRef myBundle = QLPreviewRequestGetGeneratorBundle(preview);
NSUserDefaults *defaults = [[NSUserDefaults alloc] initWithSuiteName:kSettingsSuiteName];
if (!(newQuickLook || [defaults boolForKey:kSettingsSnapshotAlways]))
if (![defaults boolForKey:kSettingsSnapshotAlways])
@autoreleasepool // Reduce peak footprint
{
Player *player = [Player playerWithURL:(__bridge NSURL *)url];
Expand Down

0 comments on commit 8e392b1

Please sign in to comment.