fix(bidcaching):remove teads from bidcaching #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/targeting.js
Outdated
| bidsToProcess = bidsToFilter.filter(bid => isBidSizeAllowed(bid, allowedSizes)); | ||
| bidsToProcess = bidsToFilter | ||
| .filter(bid => isBidSizeAllowed(bid, allowedSizes)) | ||
| .filter(bid => !(isBidCached(bid) && getBidName(bid) === 'teads')); |
There was a problem hiding this comment.
I would set an array of blacklisted bidders in order to make it easier add new ones to the black list if we don't want to perform bid caching on them. Moreover, what do you think to gather it on a different function? Something like:
isBidAllowed = () => !(isBidCached(bid) && blacklistedCacheBidders.includes(getBidName(bid)))
There was a problem hiding this comment.
Besides that, we could add a test to cover it.
oscarmarimrf
previously approved these changes
Mar 18, 2020
oscarmarimrf
dismissed
their stale review
I approved it too early, we still need the tests 😅
oscarmarimrf
approved these changes
Mar 19, 2020
pedrolopezmrf
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.