Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when closing the socket #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JoachimVeulemans
Copy link

A bug appears when closing the socket:
'Cannot access a disposed object. Object name: System.Net.Sockets.Socket.'

According to the documentation, a 'Shutdown' should always be called before closing the Socket:
https://learn.microsoft.com/en-us/dotnet/api/System.Net.Sockets.Socket.Close?view=netframework-4.8

Would it be possible to compile another version and update NuGet?

Many thanks!

@MarcusWichelmann
Copy link
Owner

MarcusWichelmann commented Mar 15, 2023

Hi,

thanks for your pull request, but I don't plan to do any new releases of this library, as stated in the README.

I think it's better to let this library die. You would be better off with switching to another library or implementing the very little logic, that's needed for asynchronous TCP sockets, yourself. It will probably even turn out better than how this library implements things.

Same goes for https://github.com/MarcusWichelmann/LibMJPEGServer, which is probably the only reason anyone is still using this library. But that's also way outdated and very unoptimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants