Fix: express (#38)

* fix express fixture * remove node-fetch dependency
MarcusFelling · Jun 27, 2023 · 3034fa5 · 3034fa5
1 parent 1423484
commit 3034fa5
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 131 deletions.
diff --git a/fixtures/tests/express-test.ts b/fixtures/tests/express-test.ts
@@ -36,8 +36,8 @@ const test = base.extend<{}, ExpressWorkerFixtures>({
     // Start the server.
     let server;
     console.log('Starting server...');
-    await new Promise((f) => {
-      server = app.listen(port);
+    await new Promise<void>((resolve) => {
+      server = app.listen(port, () => resolve());
     });
     console.log('Server ready');
 

diff --git a/fixtures/tests/express.spec.ts b/fixtures/tests/express.spec.ts
@@ -3,7 +3,6 @@
  * @see https://playwright.dev/docs/test-fixtures#worker-fixtures
  */
 import test from './express-test';
-import fetch from 'node-fetch';
 
 test('fetch 1', async ({port}) => {
   const result = await fetch(`http://localhost:${port}/1`);

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -29,7 +29,6 @@
     "@axe-core/playwright": "^4.4.4",
     "express": "^4.17.2",
     "lighthouse": "^9.5.0",
-    "node-fetch": "^3.1.0",
     "typescript": "^4.5.5"
   }
 }