feat: Support configuration in .cython-lint.toml #104
Conversation
|
@MarcoGorelli Any estimate for an upcoming release with this feature? |
|
hey @dalcinl , I just pushed one out, does it work for you? |
|
Yes, it works perfectly! There is a minor nit, though, unrelated to this PR. Calling $ cython-lint
Traceback (most recent call last):
File "/home/dalcinl/.local/bin/cython-lint", line 8, in <module>
sys.exit(main())
^^^^^^
File "/home/dalcinl/.local/lib/python3.12/site-packages/cython_lint/cython_lint.py", line 930, in main
config = {k.replace("-", "_"): v for k, v in _get_config(paths).items()}
^^^^^^^^^^^^^^^^^^
File "/home/dalcinl/.local/lib/python3.12/site-packages/cython_lint/cython_lint.py", line 880, in _get_config
root = pathlib.Path(os.path.commonpath(paths))
^^^^^^^^^^^^^^^^^^^^^^^^^
File "<frozen posixpath>", line 550, in commonpath
ValueError: commonpath() arg is an empty sequenceThis should either print usage and exit with error code, or maybe better make it equivalent to |
Sounds good |
So, don't you like this other alternative? It is the behavior of |
| @@ -768,6 +768,17 @@ def test_config_file(tmpdir: Any, capsys: Any) -> None: | |||
| for file in cython_files: | |||
| assert f'{file}:1:11: E701 multiple statements on one line' in out | |||
|
|
|||
| # .cython-lint.toml takes precedence, even if empty | |||
| config_file = os.path.join(tmpdir, '.cython-lint.toml') | |||
There was a problem hiding this comment.
nit: it's best to write separate test functions for separate cases. Otherwise, the test report is messy and parts of a test function may not even run when there's problems.
| # .cython-lint.toml takes precedence over | ||
| # pyproject.toml even when it is empty | ||
| if basename == '.cython-lint.toml': | ||
| return config |
There was a problem hiding this comment.
I have a feeling that the tests don't cover this case so it can break suddenly..
Fixes #84.
cc @webknjaz