Avoid storing empty singleton on class itself in python implementation #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few things going on here, but this solves the immediate problem that anyone anywhere constructing an empty frozendict when using the python implementation will change the behavior for subsequent calls to
dill.dumps
.The larger issue, that I don't really know how to solve satisfactorily, is that dill thinks it needs to pickle the class itself rather than a reference to it. I will open an issue with more details about that.
See: #87 #88