Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify reference to 'extent' #220

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Clarify reference to 'extent' #220

merged 1 commit into from
Oct 20, 2021

Conversation

Malvoz
Copy link
Member

@Malvoz Malvoz commented Oct 20, 2021

I think "see below" refers to the extent element.

Fix #218.

@Malvoz Malvoz requested a review from prushforth October 20, 2021 15:22
prushforth
prushforth approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@prushforth prushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prushforth
Copy link
Member

The statement "The extent/@Units value SHALL be taken to be the authoritative declaration of the TCRS for a MapML document." is quite strong and will have to change, especially if we are able to implement multiple <extent> elements. The extent@units will always specify the TCRS of the <extent> it belongs to, however.

@Malvoz Malvoz merged commit bfad642 into Maps4HTML:gh-pages Oct 20, 2021
@Malvoz Malvoz deleted the extent branch October 20, 2021 22:26
@Malvoz Malvoz mentioned this pull request Oct 20, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prushforth prushforth prushforth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarification in the Extents description needed
2 participants
@Malvoz @prushforth