Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support of PHP 7.1 add up to 8.0 #24

Merged

Conversation

natmchugh
Copy link

@natmchugh natmchugh commented Jan 4, 2021

Fixes #22

@michaeljoseph
Copy link
Contributor

Perhaps you need to include 989d9c6 as well?

@michaeljoseph
Copy link
Contributor

michaeljoseph commented Jan 4, 2021

Looks like Xdebug 3 needs a XDEBUG_MODE=coverage envvar for php 7.3 and 7.4.

sebastianbergmann/php-code-coverage#834
https://travis-ci.community/t/xdebug-3-is-installed-by-default-breaking-builds/10748

And php 8.0 needs an upgrade of squizlabs/php_codesniffer because this deprecation became a fatal:

PHP Fatal error:  Array and string offset access syntax with curly braces is no longer supported in /home/travis/build/MapleSyrupGroup/dbsampler/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php on line 453

@natmchugh natmchugh force-pushed the update-ci-php-build-versions branch from 83a42c9 to f5d6aec Compare January 4, 2021 16:43
composer.json Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@martinmca martinmca merged commit 3357f1f into MapleSyrupGroup:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CI to build on current PHP versions
3 participants