!Refactor PointCloud class for better handling of multi-count fields #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- BREAKING CHANGE: Changed the way field names are generated when there is more than one count. - BREAKING CHANGE: Renamed `count` property to `counts` and returns a tuple of counts for each field. - BREAKING CHANGE: Modified the `fields` property to repeat fields if necessary based on the number of counts. - BREAKING CHANGE: Modified the `types` property to repeat types if necessary based on the number of counts. - Updated unit tests to include cases with multiple counts and ensured that the correct field names, types, and counts are returned. Signed-off-by: urasakikeisuke <[email protected]>
urasakikeisuke
added
the
rd/fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
PointCloudclass to better support multi-count fields.This PR has breaking changes
countparameter tocountsinfrom_points()method.PointCloudclass.PointCloudclass