forked from wellcometrust/grants_tagger_light
-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate Retagging Experimentation #19
Open
agombert
wants to merge
26
commits into
main
Choose a base branch
from
validate_5_tags
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsorros
reviewed
Oct 18, 2023
@@ -30,7 +30,7 @@ class BertMeshTrainingArguments(TrainingArguments): | |||
default=8 | |||
) # set to 256 in grants-tagger repo | |||
per_device_eval_batch_size: int = field(default=8) | |||
gradient_accumulation_steps: int = field(default=1) | |||
gradient_accumulation_steps: int = field(default=2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should not change the defaults ideally, just the params that get passed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put back the default to 1 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate Retagging Experimentation
In this pull request, we validate the experimentation results for retagging using a newly corrected/retagged file. The goal is to assess the performance of the updated model trained on this new data.
New Data Source
The new data source can be found in
/data/raw/retagging
, specifically in the file namedallMeSH_2021.2016-2021.jsonl
. This dataset contains corrected and retagged annotations for various documents. Notably, it includes annotations for five key tags: "Artificial Intelligence," "HIV," "Data Collection," "Mathematics," and "Geography."Environment Setup
Before validating the experimentation results, it is essential to set up the environment correctly. Here are the steps to follow:
main
branch.WANDB_API_KEY
).Launching Preprocessing and Training
To validate the experimentation, we will perform preprocessing and training using one of the following methods:
Method: Using DVC
pipelines/bertmesh/
directory.After Training
After initiating the training, please wait until the process completes. Once training is finished, we will proceed with the evaluation of model performance.
The next steps include running examples of documents with problematic tags using the model that is currently in use and the model that you have trained. The results should demonstrate an improvement in tagging accuracy and alignment with the newly corrected and retagged dataset.