-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add js libs #52
Merged
Merged
Add js libs #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjsharp1
approved these changes
Feb 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
bhgomes
suggested changes
Feb 4, 2022
bhgomes
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
see also https://github.com/Manta-Network/manta-js/pull/22
Move the end to end test pipeline plus relevant libraries from manta-js to this repo. Most files are simply moved from there unchanged, with a few exceptions:
-Tweaked the release pipeline to cache files based on
matrix.os
instead ofrunner.os
. This was inconsistently causing one of the Ubuntu builds to fails. cc @tommyjk21-Changed
simulator
code to avoid zero-value private transfers, which the runtime doesn't allow cc @bhgomes-Moved
simulator
directory intoe2e
. It seems like the simulator "belongs to" the end to end test, and it's strange to have a rust package at the top level of thejs
folder. In any case, I think this is getting replaced soon. cc @bhgomesBefore we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Files changed
in the Github PR explorer.