-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup for Testnet Release #25
Conversation
bhgomes
commented
Dec 1, 2021
•
edited
Loading
edited
- add password retry (Closes Handle incorrect password #18) @bhgomes
- handle closing windows (closes Handle close window #19 closes Can't quit sometimes #20) @Kevingislason
- add testing workflow @bhgomes
- add release strategy @bhgomes
@Kevingislason Could you take a look at the JS code whenever you have the chance? I believe I have the new state machine working, but there seem to be issues with the UI in general. I'll try and solve them tomorrow as well. |
re: closing windows: I retained decorations. If the user tries to close the window on the main page, nothing happens. If the user tries to close the window on the about page, the about window gets hidden. I tried handling close window requests more intelligently, so that closing the window during authorize declines the transaction. It's less clear how to handle window close during "sign in" and "create account". Suffice it to say, this approach is far more trouble than it's worth. I got declining transactions on close window to work, but sign in was a problem--if you close the Sign in window, when does it reopen? There are some major problems communicating between the service, the rust tauri code, and the front end. After giving up on the above, I tried getting rid of decorations, but I couldn't figure out how to round the corners of signer's window, which makes it unacceptably ugly. |
Yeah, I think probably the correct answer is that if they close the window on create account or login it should quit the app entirely. This will require some extra state, so I didn't implement it for now.
You can make the window transparent (in the Tauri config) and then do a nonzero border-radius in the CSS. Let's keep decorations for now though. |
#[cfg(debug_assertions)] | ||
let url = config.dev_origin_url.as_str(); | ||
#[cfg(not(debug_assertions))] | ||
let url = config.prod_origin_url.as_str(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have anything against us allowing both CORS urls always? It is a bit inconvenient to have to manage separate prod and dev builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want the localhost
allowed on the production build. That's a super easy way to spoof the frontend with a trojan and we should also not test some production parts with non-production parts. I just wish there was a better way to structure this instead of relying on debug_assertions
which is a bit sketchy but technically safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran the tests on deployed version of testnet UI, everything working
LGTM