Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Signer in Rust #13

Merged
merged 22 commits into from
Oct 28, 2021
Merged

Rewrite Signer in Rust #13

merged 22 commits into from
Oct 28, 2021

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented Oct 22, 2021

Features

  • Rewrote the signer server implementation in Rust with basic HTML/JS UI for password input
  • Can now leverage tauri for simple/portable application bundling
  • Added test server implementation

TODO

  • Check that the HTTP/CORS interface matches with frontend (@Kevingislason @bhgomes)
  • Use resolve_path to add a global directory to put the root_seed/private_transfer_pk/reclaim_pk. This will also require the ability to re-compute the keys when they are missing. (@bhgomes)
  • Add zeroize and/or secrecy adapters for passwords (@bhgomes)

@bhgomes bhgomes changed the title Rewrite Signer in Rust Finish Signer Implementation for Testnet Oct 22, 2021
@bhgomes bhgomes marked this pull request as ready for review October 26, 2021 22:16
@bhgomes bhgomes changed the title Finish Signer Implementation for Testnet Rewrite Signer in Rust Oct 26, 2021
src/service.rs Show resolved Hide resolved
src/service.rs Show resolved Hide resolved
Copy link
Contributor

@Kevingislason Kevingislason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

re: Shumo's comment, I lean towards move batching logic to manta-api instead of the reverse, since idk we might eventually have different implementations of signer, and we could re-use that logic. But obvs not important now.

ui/README.md Outdated Show resolved Hide resolved
@bhgomes
Copy link
Contributor Author

bhgomes commented Oct 28, 2021

re: Shumo's comment, I lean towards move batching logic to manta-api instead of the reverse, since idk we might eventually have different implementations of signer, and we could re-use that logic. But obvs not important now.

👍 It'll probably all be in manta-rs anyway by the time this is really relevant.

@bhgomes bhgomes requested a review from stechu October 28, 2021 04:34
@stechu stechu merged commit 4e77bdc into master Oct 28, 2021
@bhgomes bhgomes deleted the tauri-rebuild branch October 28, 2021 08:55
@bhgomes bhgomes added the L-changed Changelog: add these changes to the `changed` section of the changelog label Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L-changed Changelog: add these changes to the `changed` section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants