Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade tauri, add some messages #116

Merged
merged 6 commits into from
Jun 17, 2022
Merged

Upgrade tauri, add some messages #116

merged 6 commits into from
Jun 17, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 17, 2022 •
edited by bhgomes
Loading

Add token for workflow trigger, add some error hints.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Test following procedure in docs/testing-workflow.md
  • Updated relevant documentation in the code.
  • Re-reviewed Files changed in the Github PR explorer.
  • Update the version numbers properly:
    • Cargo.toml
    • ui/package.json
    • ui/public/about.html
    • ui/src-tauri/Cargo.toml
    • ui/src-tauri/tauri.conf.json
    • www/src/App.tsx

@ghost ghost added the release:patch Release: generate a patch release tag label Jun 17, 2022
@vercel
Copy link

vercel bot commented Jun 17, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
manta-signer ✅ Ready (Inspect) Visit Preview Jun 17, 2022 at 9:36PM (UTC)

@ghost ghost requested review from bhgomes, codecarrier1, dp3000 and Kevingislason June 17, 2022 21:34
bhgomes
bhgomes approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@bhgomes bhgomes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Don't forget to link the relevant issues you close with this PR:
Screen Shot 2022-06-17 at 18 01 28

And, also add the changelog:skip so that this PR doesn't go into the automatic release notes.

.github/workflows/create_release.yaml Show resolved Hide resolved
@bhgomes bhgomes added the L-skip Changelog: skip adding these changes to the changelog label Jun 17, 2022
Kevingislason
Kevingislason approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@Kevingislason Kevingislason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhgomes bhgomes linked an issue Jun 17, 2022 that may be closed by this pull request
Bad Formatting for Password Error String #112
Closed
@bhgomes bhgomes merged commit c5cf2a6 into main Jun 17, 2022
@bhgomes bhgomes deleted the upgrade-tauri-1.0 branch June 17, 2022 22:25
@bhgomes bhgomes added L-changed Changelog: add these changes to the `changed` section of the changelog and removed L-skip Changelog: skip adding these changes to the changelog labels Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codecarrier1 codecarrier1 Awaiting requested review from codecarrier1

@dp3000 dp3000 Awaiting requested review from dp3000

Assignees
No one assigned
Labels
L-changed Changelog: add these changes to the `changed` section of the changelog release:patch Release: generate a patch release tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad Formatting for Password Error String
3 participants
@bhgomes @Kevingislason @kdense521