Change requirements handling #475
Conversation
…-18_11-15-16 [REQUIREMENTS] Update requirements.txt
…-18_11-56-58 [REQUIREMENTS] Update requirements.txt
[REQUIREMENTS] Update requirements.txt
…to change-requirements-handling
[REQUIREMENTS] Update requirements.txt
# Conflicts: # requirements/requirements.txt # requirements/requirements_loose.txt
…to change-requirements-handling
[REQUIREMENTS] Update requirements.txt
requirements/requirements.txt
Outdated
| xxhash==3.4.1 | ||
| torchmetrics==1.4.0.post0 | ||
| transformers==4.40.2 | ||
| alphabase==1.5.0 |
There was a problem hiding this comment.
Shouldn't this be the requirements from the old requirements_loose.txt?
E.g. the minimal known constraints for feature compatability.
alpharaw>=0.3.1
alphatims>=1.0.8
alphabase>=1.5.0
peptdeep>=1.3.0
directlfq>=0.2.19
transformers<=4.40.2
numpy<2
scipy>=1.12.0
There was a problem hiding this comment.
agree .. note that I dropped the constraint on transformers as we do support the latest version now
[REQUIREMENTS] Update requirements.txt
| nvidia-cublas-cu12==12.4.5.8 | ||
| nvidia-cuda-cupti-cu12==12.4.127 | ||
| nvidia-cuda-nvrtc-cu12==12.4.127 | ||
| nvidia-cuda-runtime-cu12==12.4.127 | ||
| nvidia-cudnn-cu12==9.1.0.70 | ||
| nvidia-cufft-cu12==11.2.1.3 | ||
| nvidia-curand-cu12==10.3.5.147 | ||
| nvidia-cusolver-cu12==11.6.1.9 | ||
| nvidia-cusparse-cu12==12.3.1.170 | ||
| nvidia-cusparselt-cu12==0.6.2 | ||
| nvidia-nccl-cu12==2.21.5 | ||
| nvidia-nvjitlink-cu12==12.4.127 | ||
| nvidia-nvtx-cu12==12.4.127 |
There was a problem hiding this comment.
Note that these seem to be linux-specific, cf. https://github.com/MannLabs/alphadia/actions/runs/13411418109/job/37462368960#step:10:141
(same with triton)
We could add such dependencies to some "blacklist"?
Then the process would be:
- upgrade a dependency
- run freeze workflow
- run full test matrix
- in case of error: update blacklist and repeat from 2.?
@GeorgWa ?
There was a problem hiding this comment.
basically, this would be a manually curated constraints.txt file,
nvidia-nvtx-cu12 ; sys_platform != 'linux'
...
triton ; sys_platform != 'linux'
which will be considered by the workflow when creating _requirements.freeze.txt
note that there might be other occasions for such a mechanism:
MannLabs/alphapeptdeep#227 (comment)
There was a problem hiding this comment.
would look like this https://github.com/MannLabs/alphadia/pull/484/files
…-19_11-58-11 [REQUIREMENTS] Update requirements.txt
Changing handling of requirements:
@GeorgWa please check the changes to
requirements.txt, maybe some constraints need to be re-added?