Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer Library Bug #382

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Transfer Library Bug #382

merged 4 commits into from
Nov 26, 2024

Conversation

GeorgWa
Copy link
Collaborator

@GeorgWa GeorgWa commented Nov 22, 2024

  • handle cases where search output doesn't have calibrated values (rt_calibrated...) gracefully
  • some slight improvements to fix warnigns along the way

@GeorgWa GeorgWa requested review from mo-sameh and mschwoer November 22, 2024 12:59
@GeorgWa GeorgWa added bug Something isn't working test:e2e End to end tests will be run on PRs that carry this label. labels Nov 22, 2024
@GeorgWa GeorgWa added test:e2e End to end tests will be run on PRs that carry this label. and removed test:e2e End to end tests will be run on PRs that carry this label. labels Nov 22, 2024
mschwoer
mschwoer reviewed Nov 22, 2024
View reviewed changes
alphadia/outputaccumulator.py Outdated Show resolved Hide resolved
alphadia/outputaccumulator.py Outdated Show resolved Hide resolved
alphadia/workflow/peptidecentric.py Outdated Show resolved Hide resolved
@GeorgWa GeorgWa added test:e2e End to end tests will be run on PRs that carry this label. and removed test:e2e End to end tests will be run on PRs that carry this label. labels Nov 25, 2024
@GeorgWa GeorgWa requested a review from mschwoer November 25, 2024 16:12
@GeorgWa GeorgWa merged commit 3913b0e into development Nov 26, 2024
5 checks passed
@GeorgWa GeorgWa deleted the transfer-lib-bug branch November 26, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschwoer mschwoer mschwoer approved these changes

@mo-sameh mo-sameh Awaiting requested review from mo-sameh

Assignees
No one assigned
Labels
bug Something isn't working test:e2e End to end tests will be run on PRs that carry this label.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeorgWa @mschwoer