Make fragment calibration configurable #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odespard
added
the
test:e2e
mschwoer
approved these changes
Aug 26, 2024
Base automatically changed from
make_convergence_configurable
to
new_rt_convergence_criteria
August 26, 2024 13:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the version of automatic calibration that has performed the best is from before we fixed the bug that artificially reduced the number of fragments we picked relative to our intention; it always picked the 500 best fragments. It is possible that calibrating on this higher-quality set meaningfully improves performance and this can be tested by making this parameter configurable.
NB: I have not made the min_fragments configurable because I don't think that the min_fragments code actually has any effect on the way the code currently runs (if there are fewer fragments than min_fragments, calibration still proceeds with the lower number). I may therefore remove it soon.