Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make convergence configurable #322

Merged
merged 8 commits into from
Aug 26, 2024

Conversation

odespard
Copy link
Collaborator

@odespard odespard commented Aug 23, 2024

Currently the new convergence rule is True by default for RT and False by default for the other three.

@odespard odespard requested a review from mschwoer August 23, 2024 11:55
@odespard odespard added the test:e2e End to end tests will be run on PRs that carry this label. label Aug 23, 2024
@odespard odespard removed the test:e2e End to end tests will be run on PRs that carry this label. label Aug 23, 2024
alphadia/workflow/optimization.py Outdated Show resolved Hide resolved
@odespard odespard merged commit 470dac7 into new_rt_convergence_criteria Aug 26, 2024
5 checks passed
@odespard odespard deleted the make_convergence_configurable branch August 26, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants