Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make optimization configurable #318

Merged
merged 11 commits into from
Aug 23, 2024
Merged

Make optimization configurable #318

merged 11 commits into from
Aug 23, 2024

Conversation

odespard
Copy link
Collaborator

Add a new optimization field in the config which can be used to specify the update rule parameters and the order of optimization.

Base automatically changed from new_dynamic_optimization_lock to development August 21, 2024 21:08
mschwoer
mschwoer reviewed Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@mschwoer mschwoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions for simplifications

alphadia/constants/default.yaml Show resolved Hide resolved
alphadia/constants/default.yaml Outdated Show resolved Hide resolved
alphadia/workflow/optimization.py Show resolved Hide resolved
alphadia/workflow/peptidecentric.py Show resolved Hide resolved
@odespard odespard added the test:e2e End to end tests will be run on PRs that carry this label. label Aug 22, 2024
@odespard odespard mentioned this pull request Aug 22, 2024
Merged
@odespard odespard requested a review from mschwoer August 22, 2024 15:43
@odespard odespard added test:e2e End to end tests will be run on PRs that carry this label. and removed test:e2e End to end tests will be run on PRs that carry this label. labels Aug 22, 2024
mschwoer
mschwoer approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@mschwoer mschwoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alphadia/constants/default.yaml Show resolved Hide resolved
alphadia/workflow/peptidecentric.py Show resolved Hide resolved
@odespard odespard merged commit 2098ba4 into development Aug 23, 2024
5 checks passed
@odespard odespard deleted the make_configurable branch August 23, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgWa GeorgWa GeorgWa left review comments

@mschwoer mschwoer mschwoer approved these changes

Assignees
No one assigned
Labels
test:e2e End to end tests will be run on PRs that carry this label.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@odespard @GeorgWa @mschwoer