timing manager #306
Merged
timing manager #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschwoer
reviewed
Aug 19, 2024
| @@ -894,6 +897,8 @@ def extraction(self): | |||
|
|
|||
| self.log_precursor_df(precursor_df) | |||
|
|
|||
| self.timing_manager.end("extraction") | |||
There was a problem hiding this comment.
if self.timing_manager.start("extraction") was called again, this would overwrite the previously recorded timeing, right? is this intended? or should we change it such that it accumulates?
There was a problem hiding this comment.
I suppose it would. Why would we want to start the same timing twice though (unless we were trying to time iterations of a loop or something like that, but then I think we would need to make the whole logic of the timing manager considerably more complex)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For tracking performance of different optimization methods, it will be useful to know how long it takes to perform both optimization and extraction for a given file. In this revision, this information is recorded by the timing manager and returned to the user in the stat.tsv file.