Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup unused numba functions #273

Merged
merged 10 commits into from
Jul 15, 2024
Merged

Cleanup unused numba functions #273

merged 10 commits into from
Jul 15, 2024

Conversation

GeorgWa
Copy link
Collaborator

@GeorgWa GeorgWa commented Jul 13, 2024

No description provided.

@GeorgWa GeorgWa marked this pull request as ready for review July 13, 2024 12:13
@GeorgWa GeorgWa requested a review from mschwoer July 13, 2024 12:13
@GeorgWa GeorgWa added the test:e2e End to end tests will be run on PRs that carry this label. label Jul 13, 2024
mschwoer
mschwoer approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@mschwoer mschwoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, that was quite some unused code

@GeorgWa
Copy link
Collaborator Author

GeorgWa commented Jul 15, 2024

wow, that was quite some unused code

The best way how to push test coverage 🙌

Base automatically changed from improved-e2e to development July 15, 2024 08:47
@GeorgWa GeorgWa merged commit 148857e into development Jul 15, 2024
4 checks passed
@GeorgWa GeorgWa deleted the cleanup branch July 15, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschwoer mschwoer mschwoer approved these changes

Assignees
No one assigned
Labels
test:e2e End to end tests will be run on PRs that carry this label.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeorgWa @mschwoer