Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix warnings for scheduler step and early stopping #252

Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix warnings for scheduler step and early stopping #252

merged 1 commit into from
Jun 25, 2024

Conversation

mo-sameh
Copy link
Collaborator

Fixed 3 causes of warnings for the transfer learning module:

  1. Step deprecated interface of passing epoch Update learning rate scheduler API #248
  2. Verbose depreciated argument in the initialization of the the PyTorch ReduceLrOnPlateau.
  3. Early stopping first iteration invalid value encountered in scalar divide.

mschwoer
mschwoer approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@mschwoer mschwoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GeorgWa GeorgWa merged commit 9583680 into development Jun 25, 2024
4 checks passed
@GeorgWa GeorgWa deleted the fix-transferlearning-warnings branch June 25, 2024 19:09
@GeorgWa GeorgWa added the bug Something isn't working label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschwoer mschwoer mschwoer approved these changes

@GeorgWa GeorgWa Awaiting requested review from GeorgWa

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mo-sameh @mschwoer @GeorgWa