Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT modular FDR core implementation #229

Merged
merged 7 commits into from
Jun 19, 2024
Merged

FEAT modular FDR core implementation #229

merged 7 commits into from
Jun 19, 2024

Conversation

GeorgWa
Copy link
Collaborator

@GeorgWa GeorgWa commented Jun 15, 2024 •
edited
Loading

This is the core FDR implementation for more modular FDR calculation across alphaDIA.
This PR introduces the fdrx module (to be renamed) which consolidates fdr.py and fdrexperimental.py.

@GeorgWa GeorgWa changed the title FEAT More flexible FDR implementation FEAT modular FDR core implementation Jun 15, 2024
@GeorgWa GeorgWa marked this pull request as ready for review June 15, 2024 23:21
mschwoer
mschwoer approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@mschwoer mschwoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alphadia/fdrx/base.py Outdated Show resolved Hide resolved
alphadia/fdrx/base.py Outdated Show resolved Hide resolved
alphadia/fdrx/base.py Show resolved Hide resolved
alphadia/fdrx/base.py Outdated Show resolved Hide resolved
alphadia/fdrx/base.py Outdated Show resolved Hide resolved
alphadia/fdrx/base.py Show resolved Hide resolved
alphadia/fdrx/stats.py Show resolved Hide resolved
alphadia/fdrx/stats.py Show resolved Hide resolved
tests/unit_tests/test_fdrx_base.py Show resolved Hide resolved
tests/unit_tests/test_fdrx_ploting.py Outdated Show resolved Hide resolved
ammarcsj
ammarcsj approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@ammarcsj ammarcsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Some small comments attached.

alphadia/fdrx/base.py Show resolved Hide resolved
alphadia/fdrx/stats.py Outdated Show resolved Hide resolved
alphadia/fdrx/stats.py Show resolved Hide resolved
alphadia/fdrx/base.py Show resolved Hide resolved
@GeorgWa GeorgWa merged commit c5f629b into development Jun 19, 2024
4 checks passed
@GeorgWa GeorgWa deleted the fdr-update branch June 19, 2024 14:36
@GeorgWa GeorgWa added the enhancement New feature or request label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschwoer mschwoer mschwoer approved these changes

@ammarcsj ammarcsj ammarcsj approved these changes

@jalew188 jalew188 Awaiting requested review from jalew188

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GeorgWa @ammarcsj @mschwoer