Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT Use parquet files as output #222

Merged
merged 7 commits into from
Jun 13, 2024
Merged

FEAT Use parquet files as output #222

merged 7 commits into from
Jun 13, 2024

Conversation

GeorgWa
Copy link
Collaborator

@GeorgWa GeorgWa commented Jun 11, 2024

This PR changes the default behavior of alphaDIA to use binary parquet files for all intermediate outputs.
Furthermore, the user get's an option in config['search_output']['file_format'] to receive all parquet outputs

@GeorgWa GeorgWa requested review from mschwoer, mo-sameh and jalew188 and removed request for mschwoer June 11, 2024 15:52
@GeorgWa GeorgWa changed the title FEAT Use parquet for intermediate files FEAT Use parquet files as output Jun 11, 2024
Copy link
Collaborator

@mschwoer mschwoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alphadia/consensus/utils.py Outdated Show resolved Hide resolved
alphadia/consensus/utils.py Show resolved Hide resolved
alphadia/constants/default.yaml Outdated Show resolved Hide resolved
alphadia/outputtransform.py Show resolved Hide resolved
alphadia/outputtransform.py Outdated Show resolved Hide resolved
alphadia/workflow/peptidecentric.py Outdated Show resolved Hide resolved
tests/unit_tests/conftest.py Outdated Show resolved Hide resolved
tests/unit_tests/conftest.py Show resolved Hide resolved
tests/unit_tests/conftest.py Show resolved Hide resolved
@GeorgWa GeorgWa marked this pull request as ready for review June 13, 2024 01:05
@GeorgWa GeorgWa merged commit 2eb3f5b into development Jun 13, 2024
3 checks passed
@GeorgWa GeorgWa deleted the parquet-intermediate branch June 13, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants